tr_image: do not rely on previously set data for _cinematic, make sure it cannot be detected as RED

illwieckz · illwieckz · commit d4cea8495b20 · 2025-09-08T20:22:34.000+02:00
diff --git a/src/engine/renderer/tr_image.cpp b/src/engine/renderer/tr_image.cpp
@@ -2834,6 +2834,9 @@ void R_CreateBuiltinImages()
 	imageParams.bits = IF_NOPICMIP;
 	imageParams.wrapType = wrapTypeEnum_t::WT_CLAMP;
 
+	// Don't reuse previously set data, we test the values for selecting the upload format.
+	memset( data, 255, sizeof( data ) );
+
 	for ( image_t * &image : tr.cinematicImage )
 	{
 		image = R_CreateImage( "_cinematic", ( const byte ** ) &dataPtr, 1, 1, 1, imageParams );

Original file line number	Diff line number	Diff line change
`@@ -2834,6 +2834,9 @@ void R_CreateBuiltinImages()`
`2834`	`2834`	`imageParams.bits = IF_NOPICMIP;`
`2835`	`2835`	`imageParams.wrapType = wrapTypeEnum_t::WT_CLAMP;`
`2836`	`2836`
	`2837`	`+ // Don't reuse previously set data, we test the values for selecting the upload format.`
	`2838`	`+ memset( data, 255, sizeof( data ) );`
	`2839`	`+`
`2837`	`2840`	`for ( image_t * &image : tr.cinematicImage )`
`2838`	`2841`	`{`
`2839`	`2842`	`image = R_CreateImage( "_cinematic", ( const byte ** ) &dataPtr, 1, 1, 1, imageParams );`