Applied rules:

 * ExplicitPublicClassMethodRector
 * CountArrayToEmptyArrayComparisonRector

Author: DanProgs

lib/ajax/gettprojectnodes.php

@@ -220,7 +220,7 @@ function getAllTCasesID($idList, &$tcIDs)
                 $suiteIDs[] = $row['id'];
             }
         }
-        if (count($suiteIDs)) {
+        if ($suiteIDs !== []) {
             $suiteIDs = implode(",", $suiteIDs);
             getAllTCasesID($suiteIDs, $tcIDs);
         }

lib/functions/code_testing/dBug.php

@@ -130,7 +130,7 @@ private function getVariableName()
     }
 
     // create the main table header
-    function makeTableHeader($type, $header, $colspan = 2)
+    public function makeTableHeader($type, $header, $colspan = 2)
     {
         if (! $this->bInitialized) {
             $header = $this->getVariableName() . " (" . $header . ")";
@@ -145,7 +145,7 @@ function makeTableHeader($type, $header, $colspan = 2)
     }
 
     // create the table row header
-    function makeTDHeader($type, $header)
+    public function makeTDHeader($type, $header)
     {
         echo "<tr>
 				<td valign=\"top\" onClick='dBug_toggleRow(this)' class=\"dBug_" . $type .
@@ -154,13 +154,13 @@ function makeTDHeader($type, $header)
     }
 
     // close table row
-    function closeTDRow()
+    public function closeTDRow()
     {
         return "</td></tr>\n";
     }
 
     // error
-    function error($type)
+    public function error($type)
     {
         $error = "Error: Variable cannot be a";
         // this just checks if the type starts with a vowel or "x" and displays either "a" or "an"
@@ -177,7 +177,7 @@ function error($type)
     }
 
     // check variable type
-    function checkType($var)
+    public function checkType($var)
     {
         switch (gettype($var)) {
             case "resource":
@@ -204,20 +204,20 @@ function checkType($var)
     }
 
     // if variable is a NULL type
-    function varIsNULL()
+    public function varIsNULL()
     {
         echo "NULL";
     }
 
     // if variable is a boolean type
-    function varIsBoolean($var)
+    public function varIsBoolean($var)
     {
         $var = ($var == 1) ? "TRUE" : "FALSE";
         echo $var;
     }
 
     // if variable is an array type
-    function varIsArray($var)
+    public function varIsArray($var)
     {
         $var_ser = serialize($var);
         array_push($this->arrHistory, $var_ser);
@@ -249,7 +249,7 @@ function varIsArray($var)
     }
 
     // if variable is an object type
-    function varIsObject($var)
+    public function varIsObject($var)
     {
         $var_ser = serialize($var);
         array_push($this->arrHistory, $var_ser);
@@ -289,7 +289,7 @@ function varIsObject($var)
     }
 
     // if variable is a resource type
-    function varIsResource($var)
+    public function varIsResource($var)
     {
         $this->makeTableHeader("resourceC", "resource", 1);
         echo "<tr>\n<td>\n";
@@ -318,7 +318,7 @@ function varIsResource($var)
     }
 
     // if variable is a database resource type
-    function varIsDBResource($var, $db = "mysql")
+    public function varIsDBResource($var, $db = "mysql")
     {
         if ($db == "pgsql")
             $db = "pg";
@@ -368,7 +368,7 @@ function varIsDBResource($var, $db = "mysql")
     }
 
     // if variable is an image/gd resource type
-    function varIsGDResource($var)
+    public function varIsGDResource($var)
     {
         $this->makeTableHeader("resource", "gd", 2);
         $this->makeTDHeader("resource", "Width");
@@ -381,13 +381,13 @@ function varIsGDResource($var)
     }
 
     // if variable is an xml type
-    function varIsXml($var)
+    public function varIsXml($var)
     {
         $this->varIsXmlResource($var);
     }
 
     // if variable is an xml resource type
-    function varIsXmlResource($var)
+    public function varIsXmlResource($var)
     {
         $xml_parser = xml_parser_create();
         xml_parser_set_option($xml_parser, XML_OPTION_CASE_FOLDING, 0);
@@ -433,7 +433,7 @@ function varIsXmlResource($var)
     }
 
     // parse xml
-    function xmlParse($xml_parser, $data, $bFinal)
+    public function xmlParse($xml_parser, $data, $bFinal)
     {
         if (! xml_parse($xml_parser, $data, $bFinal)) {
             die(
@@ -444,7 +444,7 @@ function xmlParse($xml_parser, $data, $bFinal)
     }
 
     // xml: inititiated when a start tag is encountered
-    function xmlStartElement($parser, $name, $attribs)
+    public function xmlStartElement($parser, $name, $attribs)
     {
         $this->xmlAttrib[$this->xmlCount] = $attribs;
         $this->xmlName[$this->xmlCount] = $name;
@@ -463,7 +463,7 @@ function xmlStartElement($parser, $name, $attribs)
     }
 
     // xml: initiated when an end tag is encountered
-    function xmlEndElement($parser, $name)
+    public function xmlEndElement($parser, $name)
     {
         for ($i = 0; $i < $this->xmlCount; $i ++) {
             eval($this->xmlSData[$i]);
@@ -482,7 +482,7 @@ function xmlEndElement($parser, $name)
     }
 
     // xml: initiated when text between tags is encountered
-    function xmlCharacterData($parser, $data)
+    public function xmlCharacterData($parser, $data)
     {
         $count = $this->xmlCount - 1;
         if (! empty($this->xmlCData[$count]))
@@ -492,7 +492,7 @@ function xmlCharacterData($parser, $data)
     }
 
     // xml: initiated when a comment or other miscellaneous texts is encountered
-    function xmlDefaultHandler($parser, $data)
+    public function xmlDefaultHandler($parser, $data)
     {
         // strip '<!--' and '-->' off comments
         $data = str_replace(array(
@@ -506,7 +506,7 @@ function xmlDefaultHandler($parser, $data)
             $this->xmlDData[$count] = $data;
     }
 
-    function initJSandCSS()
+    public function initJSandCSS()
     {
         echo <<<SCRIPTS
         			<script language="JavaScript">

lib/functions/common.php

@@ -586,7 +586,7 @@ function strings_stripSlashes($parameter, $bGPC = true)
 
     if (is_array($parameter)) {
         $retParameter = null;
-        if (count($parameter)) {
+        if ($parameter !== []) {
             foreach ($parameter as $key => $value) {
                 if (is_array($value)) {
                     $retParameter[$key] = strings_stripSlashes($value, $bGPC);

lib/functions/csrf.php

@@ -174,7 +174,7 @@ function smarty_csrf_filter($source, $smarty)
  */
 function csrfguard_start()
 {
-    if (count($_POST)) {
+    if ($_POST !== []) {
         if (! isset($_POST['CSRFName'])) {
             redirect($_SESSION['basehref'] . 'error.php?code=1');
             exit();

lib/functions/print.inc.php

@@ -286,7 +286,7 @@ function renderReqForPrinting(&$db, $node, &$options, $reqLevel, $tprojectID)
     // since 1.9.18 => we need to use req version
     $attachSet = (array) $req_mgr->getAttachmentInfos($req['revision_id']);
 
-    if (count($attachSet)) {
+    if ($attachSet !== []) {
         $output .= "<tr><td width=\"$firstColWidth\"><span class=\"label\">" .
             $labels['attached_files'] . "</span></td><td>";
 
@@ -497,7 +497,7 @@ function renderReqSpecNodeForPrinting(&$db, &$node, &$options, $tocPrefix,
     }
 
     $attachSet = (array) $req_spec_mgr->getAttachmentInfos($spec_id);
-    if (count($attachSet)) {
+    if ($attachSet !== []) {
         $output .= "<tr><td width=\"$firstColWidth\"><span class=\"label\">" .
             $labels['attached_files'] . "</span></td><td><ul>";
 
@@ -1453,7 +1453,7 @@ function renderTestCaseForPrinting(&$db, &$node, &$options, $env, $context,
             '" valign="top"><span class="label">' . $labels['reqs'] . '</span>';
         $code .= '<td colspan="' . ($cfg['tableColspan'] - 1) . '">';
 
-        if (count($requirements)) {
+        if ($requirements !== []) {
             foreach ($requirements as $req) {
                 $code .= htmlspecialchars(
                     $req['req_doc_id'] . ":  " . $req['title']) . " " .
@@ -1479,7 +1479,7 @@ function renderTestCaseForPrinting(&$db, &$node, &$options, $env, $context,
             array(
                 'fields' => 'keyword_id,KW.keyword'
             ));
-        if (count($kwSet)) {
+        if ($kwSet !== []) {
             foreach ($kwSet as $kw) {
                 $code .= htmlspecialchars($kw['keyword']) . "<br />";
             }
@@ -1501,7 +1501,7 @@ function renderTestCaseForPrinting(&$db, &$node, &$options, $env, $context,
             array(
                 'fields' => 'platform_id,PL.name'
             ));
-        if (count($itSet)) {
+        if ($itSet !== []) {
             foreach ($itSet as $it) {
                 $code .= htmlspecialchars($it['name']) . "<br />";
             }

lib/functions/requirement_spec_mgr.class.php

@@ -1811,7 +1811,7 @@ public function getByDocID($doc_id, $tproject_id = null, $parent_id = null,
             ' GROUP BY RSPEC_REV.parent_id ';
 
         $maxi = (array) $this->db->fetchRowsIntoMap($sql_max, 'rev_id');
-        if (count($maxi) > 0) {
+        if ($maxi !== []) {
             $sql = " /* $debugMsg */ SELECT RSPEC.id,RSPEC.testproject_id,RSPEC.doc_id,NH_RSPEC.name AS title, " .
                 " RSPEC_REV.revision ";
 

lib/functions/roles.inc.php

@@ -276,7 +276,7 @@ function checkForRights($rights, $roleQuestion, $bAND = 1)
             }
         } else {
             // for OR one of all must be present
-            if (count($r)) {
+            if ($r !== []) {
                 $ret = 'yes';
             }
         }

lib/functions/testcase.class.php

@@ -3253,7 +3253,7 @@ public function getExecStatus($id, $filters = null, $options = null)
         $link_info = null;
         $in_set = null;
 
-        if (count($rs)) {
+        if ($rs !== []) {
             foreach ($rs as $idx => $elem) {
                 if ($elem['tcversion_number'] != $elem['version']) {
                     // Save to generate record for linked but not executed if needed
@@ -9645,7 +9645,7 @@ private function isLinkedTCVersion($tcVersionID, $tplanID)
 
         $rs = (array) $this->db->get_recordset($sql);
 
-        return count($rs) > 0;
+        return $rs !== [];
     }
 
     /**

lib/functions/testplan.class.php

@@ -916,7 +916,7 @@ protected function helper_keywords_sql($filter, $options = null)
                 array_shift($filter);
             }
 
-            if (count($filter)) {
+            if ($filter !== []) {
                 $sql['filter'] = " AND TK.keyword_id IN (" .
                     implode(',', $filter) . ")";
             }
@@ -3826,7 +3826,7 @@ private function exportTestSuiteDataToXML($container, $tproject_id,
 
             $cfMap = (array) $tsuiteMgr->get_linked_cfields_at_design(
                 $container['id'], null, null, $tproject_id);
-            if (count($cfMap) > 0) {
+            if ($cfMap !== []) {
                 $cfXML = $this->cfield_mgr->exportValueAsXML($cfMap);
             }
 
@@ -4794,8 +4794,8 @@ public function getHitsSameStatusFullALOP($id, $statusSet, $buildSet = null,
 
         // build results record set
         $hitsFoundOn = array();
-        $hitsFoundOn['notRun'] = count($hits['notRun']) > 0;
-        $hitsFoundOn['otherStatus'] = count($hits['otherStatus']) > 0;
+        $hitsFoundOn['notRun'] = $hits['notRun'] !== [];
+        $hitsFoundOn['otherStatus'] = $hits['otherStatus'] !== [];
 
         if ($hitsFoundOn['notRun'] && $hitsFoundOn['otherStatus']) {
             $items = array_merge(array_keys($hits['notRun']),
@@ -4935,7 +4935,7 @@ public function getHitsStatusSetOnBuildPlatform($id, $platformID, $buildID,
             array_keys($recordset));
 
         $items = (array) $hits + (array) $notRunHits;
-        return count($items) > 0 ? $items : null;
+        return $items !== [] ? $items : null;
     }
 
     /**
@@ -4997,7 +4997,7 @@ public function getHitsStatusSetOnBuildALOP($id, $buildID, $statusSet)
             array_keys($recordset));
 
         $items = (array) $hits + (array) $notRunHits;
-        return count($items) > 0 ? $items : null;
+        return $items !== [] ? $items : null;
     }
 
     /**
@@ -5210,8 +5210,8 @@ public function getHitsSameStatusPartialALOP($id, $statusSet,
 
         // build results recordset
         $hitsFoundOn = array();
-        $hitsFoundOn['notRun'] = count($hits['notRun']) > 0;
-        $hitsFoundOn['otherStatus'] = count($hits['otherStatus']) > 0;
+        $hitsFoundOn['notRun'] = $hits['notRun'] !== [];
+        $hitsFoundOn['otherStatus'] = $hits['otherStatus'] !== [];
 
         if ($get['notRun'] && $get['otherStatus']) {
             if ($hitsFoundOn['notRun'] && $hitsFoundOn['otherStatus']) {
@@ -5403,8 +5403,8 @@ private function helperGetHitsSameStatusOnPlatform($mode, $id, $platformID,
 
         // build results recordset
         $hitsFoundOn = array();
-        $hitsFoundOn['notRun'] = count($hits['notRun']) > 0;
-        $hitsFoundOn['otherStatus'] = count($hits['otherStatus']) > 0;
+        $hitsFoundOn['notRun'] = $hits['notRun'] !== [];
+        $hitsFoundOn['otherStatus'] = $hits['otherStatus'] !== [];
 
         // 20120919 - asimon - TICKET 5226: Filtering by test result did not always show the correct matches
         // if($get['notRun'] && $get['otherStatus'])

lib/functions/testproject.class.php

@@ -886,8 +886,7 @@ public function show(&$smarty, $guiObj, $template_dir, $id, $sqlResult = '',
             'testplan' => 'me',
             'requirement_spec' => 'me'
         );
-        $gui->canDoExport = count(
-            (array) $this->tree_manager->get_children($safeID, $exclusion)) > 0;
+        $gui->canDoExport = (array) $this->tree_manager->get_children($safeID, $exclusion) !== [];
         if ($modded_item_id) {
             $gui->moddedItem = $this->get_by_id(intval($modded_item_id));
         }
@@ -2224,7 +2223,7 @@ public function get_all_testcases_id($idList, &$tcIDs, $options = null)
                     $suiteIDs[] = $row['id'];
                 }
             }
-            if (count($suiteIDs)) {
+            if ($suiteIDs !== []) {
                 $suiteIDs = implode(",", $suiteIDs);
                 $this->get_all_testcases_id($suiteIDs, $tcIDs, $options);
             }