Code revised with reactor

Applied rules:
 * RemoveAlwaysElseRector
 * StaticClosureRector

Author: DanProgs

install/installStart.php

@@ -11,8 +11,6 @@
     header("Location: upgradeStart.php");
     exit;
 }
-else {
-	echo "No installationType found in \$_GET.";
-}
+echo "No installationType found in \$_GET.";
 
 ?>

lib/api/rest/v1/tlRestApi.class.php

@@ -125,7 +125,7 @@ public function __construct()
 
         // test route with anonymous function
         $this->app->get('/who',
-            function (): void {
+            static function (): void {
                 echo __CLASS__ . ' : Get Route /who';
             });
 

lib/api/rest/v2/tlRestApi.class.php

@@ -141,7 +141,7 @@ public function __construct()
         // GET Routes
         // test route with anonymous function
         $this->app->get('/who',
-            function (): void {
+            static function (): void {
                 echo __CLASS__ . ' : You have called the Get Route /who';
             });
 

lib/api/rest/v3/core/routes.php

@@ -3,7 +3,7 @@
 use Psr\Http\Message\ServerRequestInterface as Request;
 use Slim\App;
 
-return function (App $app): void {
+return static function (App $app): void {
 
     // @20201124 - I do not understand this
     // $app->get('/',World::class . ':hello');

lib/api/rest/v3/custom/routes/routesCustomExample.php

@@ -9,7 +9,7 @@
 use Slim\App;
 
 
-return function (App $app): void {
+return static function (App $app): void {
   $app->get('/CustomExample/whoAmI',
             array($app->restApiCustomExample,'whoAmI'));
 

lib/experiments/google.php

@@ -30,33 +30,26 @@
     unset($_SESSION['oauth2state']);
     exit('Invalid state');
 }
-else {
-
-    // Try to get an access token (using the authorization code grant)
-    $token = $provider->getAccessToken('authorization_code',
-        [
-            'code' => $_GET['code']
-        ]);
-
-    // Optional: Now you have a token you can look up a users profile data
-    try {
-        // We got an access token, let's now get the owner details
-        $ownerDetails = $provider->getResourceOwner($token);
-
-        // Use these details to create a new profile
-        printf('Hello %s!', $ownerDetails->getFirstName());
-    } catch (Exception $e) {
-
-        // Failed to get user details
-        exit('Something went wrong: ' . $e->getMessage());
-    }
-
-    // Use this to interact with an API on the users behalf
-    echo $token->getToken();
+// Try to get an access token (using the authorization code grant)
+$token = $provider->getAccessToken('authorization_code',
+    [
+        'code' => $_GET['code']
+    ]);
+// Optional: Now you have a token you can look up a users profile data
+try {
+    // We got an access token, let's now get the owner details
+    $ownerDetails = $provider->getResourceOwner($token);
 
-    // Use this to get a new access token if the old one expires
-    echo $token->getRefreshToken();
+    // Use these details to create a new profile
+    printf('Hello %s!', $ownerDetails->getFirstName());
+} catch (Exception $e) {
 
-    // Unix timestamp at which the access token expires
-    echo $token->getExpires();
+    // Failed to get user details
+    exit('Something went wrong: ' . $e->getMessage());
 }
+// Use this to interact with an API on the users behalf
+echo $token->getToken();
+// Use this to get a new access token if the old one expires
+echo $token->getRefreshToken();
+// Unix timestamp at which the access token expires
+echo $token->getExpires();

lib/functions/common.php

@@ -748,9 +748,7 @@ function priority_to_level($priority)
     if ($priority < $urgencyImportance->threshold['low']) {
         return LOW;
     }
-    else {
-        return MEDIUM;
-    }
+    return MEDIUM;
 }
 
 /**

lib/functions/string_api.php

@@ -296,7 +296,7 @@ function string_insert_hrefs($p_string)
     # Find any URL in a string and replace it with a clickable link
     # From MantisBT 2.25.2
     $p_string = preg_replace_callback($s_url_regex,
-        function ($p_match) {
+        static function ($p_match) {
             $t_url_href = 'href="' . rtrim($p_match[1], '.') . '"';
             if (config_get('html_make_links') == LINKS_NEW_WINDOW) {
                 $t_url_target = ' target="_blank"';