-
Notifications
You must be signed in to change notification settings - Fork 62
Closed
Labels
enhancementNew feature or requestNew feature or request
Description
Feature request description
Hey there,
I had some trouble to override the build_number for react-native xcode. I think it is because we've currently set the CFBundleShortVersionString and CFBundleVersion dynamically during the build phases. then those number will be wrote into the info.plist inside build folder directly.
I saw the release version can be set from the env DATADOG_RELEASE_VERSION. Is there any way to override the build_number in a similar way as release version? Or is there any way to read the info.plist from the build folder.
This is the custom-react-native-xcode.sh file look like at the moment.
#!/bin/sh
INFO_PLIST_PATH="${TARGET_BUILD_DIR}/${INFOPLIST_PATH}"
export DATADOG_RELEASE_VERSION=$(/usr/libexec/PlistBuddy -c "Print CFBundleShortVersionString" "${INFO_PLIST_PATH}")
REACT_NATIVE_XCODE="../node_modules/react-native/scripts/react-native-xcode.sh"
DATADOG_XCODE="../node_modules/.bin/datadog-ci react-native xcode"
/bin/sh -c "$DATADOG_XCODE $REACT_NATIVE_XCODE"
Solution
No response
Additional context
No response
Command
None
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request