-
Notifications
You must be signed in to change notification settings - Fork 468
chore: remove references to Python version 3.8 #15438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 260 ± 5 ms. The average import time from base is: 250 ± 2 ms. The import time difference between this PR and base is: 9.7 ± 0.2 ms. Import time breakdownThe following import paths have grown:
|
Performance SLOsComparing candidate taegyunkim/py38-cleanup (0425c3c) with baseline main (4753e14) 📈 Performance Regressions (2 suites)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.983µs (SLO: <10.000µs 📉 -50.2%) vs baseline: 📈 +21.4% Memory: ✅ 40.305MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +5.0% ✅ ospathbasename_noaspectTime: ✅ 1.077µs (SLO: <10.000µs 📉 -89.2%) vs baseline: -1.0% Memory: ✅ 40.364MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.3% ✅ ospathjoin_aspectTime: ✅ 6.056µs (SLO: <10.000µs 📉 -39.4%) vs baseline: -1.6% Memory: ✅ 40.344MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.0% ✅ ospathjoin_noaspectTime: ✅ 2.280µs (SLO: <10.000µs 📉 -77.2%) vs baseline: -0.6% Memory: ✅ 40.324MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +4.8% ✅ ospathnormcase_aspectTime: ✅ 3.426µs (SLO: <10.000µs 📉 -65.7%) vs baseline: +0.6% Memory: ✅ 40.324MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +4.8% ✅ ospathnormcase_noaspectTime: ✅ 0.563µs (SLO: <10.000µs 📉 -94.4%) vs baseline: -1.4% Memory: ✅ 40.324MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.1% ✅ ospathsplit_aspectTime: ✅ 4.687µs (SLO: <10.000µs 📉 -53.1%) vs baseline: -1.6% Memory: ✅ 40.403MB (SLO: <41.000MB 🟡 -1.5%) vs baseline: +5.1% ✅ ospathsplit_noaspectTime: ✅ 1.582µs (SLO: <10.000µs 📉 -84.2%) vs baseline: -0.6% Memory: ✅ 40.423MB (SLO: <41.000MB 🟡 -1.4%) vs baseline: +5.2% ✅ ospathsplitdrive_aspectTime: ✅ 3.667µs (SLO: <10.000µs 📉 -63.3%) vs baseline: +1.6% Memory: ✅ 40.423MB (SLO: <41.000MB 🟡 -1.4%) vs baseline: +4.9% ✅ ospathsplitdrive_noaspectTime: ✅ 0.693µs (SLO: <10.000µs 📉 -93.1%) vs baseline: -0.4% Memory: ✅ 40.364MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.3% ✅ ospathsplitext_aspectTime: ✅ 4.474µs (SLO: <10.000µs 📉 -55.3%) vs baseline: -0.7% Memory: ✅ 40.324MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +4.9% ✅ ospathsplitext_noaspectTime: ✅ 1.381µs (SLO: <10.000µs 📉 -86.2%) vs baseline: +0.1% Memory: ✅ 40.305MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +4.9% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.379µs (SLO: <20.000µs 📉 -83.1%) vs baseline: 📈 +15.8% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +4.9% ✅ 1-count-metrics-100-timesTime: ✅ 199.833µs (SLO: <220.000µs -9.2%) vs baseline: -0.3% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.6% ✅ 1-distribution-metric-1-timesTime: ✅ 3.241µs (SLO: <20.000µs 📉 -83.8%) vs baseline: -0.4% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +5.1% ✅ 1-distribution-metrics-100-timesTime: ✅ 212.778µs (SLO: <230.000µs -7.5%) vs baseline: -0.8% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +4.7% ✅ 1-gauge-metric-1-timesTime: ✅ 2.151µs (SLO: <20.000µs 📉 -89.2%) vs baseline: -0.8% Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.3% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.557µs (SLO: <150.000µs -9.0%) vs baseline: +0.4% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ 1-rate-metric-1-timesTime: ✅ 3.024µs (SLO: <20.000µs 📉 -84.9%) vs baseline: -0.8% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ 1-rate-metrics-100-timesTime: ✅ 214.162µs (SLO: <250.000µs 📉 -14.3%) vs baseline: +0.5% Memory: ✅ 34.977MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +5.2% ✅ 100-count-metrics-100-timesTime: ✅ 20.202ms (SLO: <22.000ms -8.2%) vs baseline: +0.9% Memory: ✅ 34.977MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +4.9% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.225ms (SLO: <2.300ms -3.3%) vs baseline: -1.0% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.408ms (SLO: <1.550ms -9.2%) vs baseline: +1.0% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +4.7% ✅ 100-rate-metrics-100-timesTime: ✅ 2.207ms (SLO: <2.550ms 📉 -13.5%) vs baseline: ~same Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.6% ✅ flush-1-metricTime: ✅ 4.406µs (SLO: <20.000µs 📉 -78.0%) vs baseline: -1.2% Memory: ✅ 35.193MB (SLO: <35.500MB 🟡 -0.9%) vs baseline: +4.9% ✅ flush-100-metricsTime: ✅ 172.782µs (SLO: <250.000µs 📉 -30.9%) vs baseline: -0.5% Memory: ✅ 35.311MB (SLO: <35.500MB 🟡 -0.5%) vs baseline: +4.7% ✅ flush-1000-metricsTime: ✅ 2.187ms (SLO: <2.500ms 📉 -12.5%) vs baseline: -0.2% Memory: ✅ 36.038MB (SLO: <36.500MB 🟡 -1.3%) vs baseline: +4.8% 🟡 Near SLO Breach (19 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
| assert "+" not in patched_code | ||
|
|
||
|
|
||
| def test_no_index_aspects_py37(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also remove that (given it refers to 3.7 which is older than 3.8)?
Description
Testing
Risks
Additional Notes