No hard-coded windows-style new line symbols

Author: alex-kulakov

Orm/Xtensive.Orm/Core/Exceptions/AggregateException.cs

@@ -60,11 +60,12 @@ public List<Exception> GetFlatExceptions()
     public override string ToString()
     {
       StringBuilder sb = new StringBuilder(64);
-      sb.Append(base.ToString());
-      sb.AppendFormat("\r\n{0}:", Strings.OriginalExceptions);
+      sb.Append(base.ToString())
+        .AppendLine()
+        .AppendFormat("{0}:", Strings.OriginalExceptions);
       int i = 1;
       foreach (Exception exception in exceptions)
-        sb.AppendFormat("\r\n{0}: {1}", i++, exception);
+        sb.AppendLine().AppendFormat("\r\n{0}: {1}", i++, exception);
       return sb.ToString();
     }
 

Orm/Xtensive.Orm/Orm/Operation.cs

@@ -139,7 +139,7 @@ public override string ToString()
     private string FormatIdentifiedEntities()
     {
       // Shouldn't be moved to resources
-      return "  Identified entities:\r\n" + (
+      return "  Identified entities:" + Environment.NewLine + (
         from pair in IdentifiedEntities
         orderby pair.Key
         select string.Format("    {0}: {1}", pair.Key, pair.Value)
@@ -150,7 +150,7 @@ select string.Format("    {0}: {1}", pair.Key, pair.Value)
     private string FormatOperations(string title, IEnumerable<IOperation> operations)
     {
       // Shouldn't be moved to resources
-      return string.Format("  {0}:\r\n", title) +
+      return string.Format("  {0}:", title) + Environment.NewLine +
         operations.ToDelimitedString(Environment.NewLine).ToString().Indent(4);
     }
 

Orm/Xtensive.Orm/Orm/OperationLog.cs

@@ -111,7 +111,8 @@ public object Replay(object target)
     /// <inheritdoc/>
     public override string ToString()
     {
-      var sb = new StringBuilder(string.Format("{0}:\r\n", Strings.Operations));
+      var sb = new StringBuilder(string.Format("{0}:", Strings.Operations));
+      _ = sb.AppendLine();
       foreach (var o in operations)
         sb.AppendLine(o.ToString().Indent(2));
       return sb.ToString().Trim();

Orm/Xtensive.Orm/Orm/Operations/KeySetOperation.cs

@@ -28,7 +28,7 @@ public abstract class KeySetOperation : Operation,
     public override string Description {
       get
       {
-        return string.Format("{0}:\r\n{1}", Title, Keys.ToDelimitedString("\r\n").Indent(2));
+        return $"{Title}:{Environment.NewLine}{Keys.ToDelimitedString(Environment.NewLine).Indent(2)}";
       }
     }
 

Orm/Xtensive.Orm/Orm/Upgrade/SchemaComparisonResult.cs

@@ -12,6 +12,7 @@
 using Xtensive.Modelling.Comparison;
 using Xtensive.Modelling.Comparison.Hints;
 using System.Linq;
+using System;
 
 namespace Xtensive.Orm.Upgrade
 {
@@ -72,7 +73,7 @@ public override string ToString()
         HasUnsafeActions.ToString().ToLower(),
         HasColumnTypeChanges.ToString().ToLower(),
         IsCompatibleInLegacyMode.HasValue ? IsCompatibleInLegacyMode.Value.ToString() : Strings.Unknown,
-        UnsafeActions.Any() ? UnsafeActions.ToDelimitedString("\r\n").Indent(2) : string.Empty,
+        UnsafeActions.Any() ? UnsafeActions.ToDelimitedString(Environment.NewLine).Indent(2) : string.Empty,
         Hints!=null ? Hints.ToString().Indent(2) : string.Empty,
         Difference!=null ? Difference.ToString().Indent(2) : string.Empty);
     }

Orm/Xtensive.Orm/Sql/Compiler/SqlTranslator.cs

@@ -25,7 +25,7 @@ public abstract class SqlTranslator : SqlDriverBound
     public NumberFormatInfo FloatNumberFormat { get; private set; }
     public NumberFormatInfo DoubleNumberFormat { get; private set; }
 
-    public virtual string NewLine { get { return "\r\n"; } }
+    public virtual string NewLine { get { return Environment.NewLine; } }
 
     public virtual string OpeningParenthesis { get { return "("; } }
     public virtual string ClosingParenthesis { get { return ")"; } }