From 3c917ed443f2911ea7225f5786bddf4fbbe25ba5 Mon Sep 17 00:00:00 2001
From: Lavi101 <102468162+Lavi101@users.noreply.github.com>
Date: Mon, 14 Jul 2025 17:06:21 +0300
Subject: [PATCH 1/2] Corrected CNOT success probability

Changed to F^2 + 2/3 F(1-F) + 5/9 (1-F)^2
---
 src/engine/operations.ts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/engine/operations.ts b/src/engine/operations.ts
index c41e190..92de783 100644
--- a/src/engine/operations.ts
+++ b/src/engine/operations.ts
@@ -100,8 +100,8 @@ export const bilateralCNOT = (control: DensityMatrix, target: DensityMatrix): {
   // the success probability depends on the fidelity F
   const f = control.get(0, 0).re;
   
-  // Success probability is p_success = f^2 + (1-f)^2/9
-  const successProbability = f * f + (1 - f) * (1 - f) / 9;
+  // Success probability is p_success = f^2 + 2 f (1-f) / 3 + 5 (1-f)^2 /9
+  const successProbability = f * f + 2 * f * (1-f) / 3 + 5 * (1-f) * (1-f) / 9;
   
   // Determine success based on probability
   const successful = Math.random() < successProbability;
@@ -168,4 +168,4 @@ export const preparePairsForCNOT = (pairs: QubitPair[]): {
     targetPairs,
     hasUnpairedPair
   };
-}; 
\ No newline at end of file
+}; 

From be5d859e7a6f1bd6366c8c9bd5a02d1e1dafbfb1 Mon Sep 17 00:00:00 2001
From: Lavi101 <102468162+Lavi101@users.noreply.github.com>
Date: Mon, 14 Jul 2025 19:08:28 +0300
Subject: [PATCH 2/2] No code duplicate fix

---
 src/engine/operations.ts | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/engine/operations.ts b/src/engine/operations.ts
index 92de783..3f6d702 100644
--- a/src/engine/operations.ts
+++ b/src/engine/operations.ts
@@ -99,9 +99,16 @@ export const bilateralCNOT = (control: DensityMatrix, target: DensityMatrix): {
   // In the BBPSSW protocol with |Φ⁺⟩ as the target state after exchange,
   // the success probability depends on the fidelity F
   const f = control.get(0, 0).re;
+
+  // Calculate improved fidelity after successful purification
+  // F' = (f^2 + (1-f)^2/9) / (f^2 + 2f(1-f)/3 + 5(1-f)^2/9)
+  const numerator = f * f + Math.pow(1 - f, 2) / 9;
+  const denominator = f * f + 2 * f * (1 - f) / 3 + 5 * Math.pow(1 - f, 2) / 9;
+  // Handle potential division by zero or NaN
+  const fPrime = denominator === 0 ? 0 : numerator / denominator;
   
   // Success probability is p_success = f^2 + 2 f (1-f) / 3 + 5 (1-f)^2 /9
-  const successProbability = f * f + 2 * f * (1-f) / 3 + 5 * (1-f) * (1-f) / 9;
+  const successProbability = denominator
   
   // Determine success based on probability
   const successful = Math.random() < successProbability;
@@ -109,13 +116,6 @@ export const bilateralCNOT = (control: DensityMatrix, target: DensityMatrix): {
   let controlPair: DensityMatrix;
   
   if (successful) {
-    // Calculate improved fidelity after successful purification
-    // F' = (f^2 + (1-f)^2/9) / (f^2 + 2f(1-f)/3 + 5(1-f)^2/9)
-    const numerator = f * f + Math.pow(1 - f, 2) / 9;
-    const denominator = f * f + 2 * f * (1 - f) / 3 + 5 * Math.pow(1 - f, 2) / 9;
-    // Handle potential division by zero or NaN
-    const fPrime = denominator === 0 ? 0 : numerator / denominator;
-    
     // Create new density matrix directly and set elements
     const controlPairResult = new DensityMatrix(Array(4).fill(0).map(() => Array(4).fill(0).map(() => ComplexNum.zero())));
     controlPairResult.set(0, 0, new ComplexNum(fPrime, 0));