Are REV and CTRE devices on spec for sim. #117
Description
figure out if REV and CTRE devices are on spec for sim. Originally posted by @CoolSpy3 in #107 (review)
On simulation:
Now that REV has rolled out an actual simulation API, I think that it makes much more sense to use that than something we hack together and maintain. (As hinted at in #101.) I propose the following:
Someone should check whether all Rev and CTRE devices are on-spec. By this, I mean that we check if, when simulating them alone (i.e. not with lib199), they create the necessary SimDevice objects with the correct names and all of the necessary values. Some of this can maybe be determined by source-code inspection.
If they support everything, YAY, we can just wipe the sim classes and use their implementation!
If they're close, but not exactly on-spec, we can email their support teams and ask for some minor corrections. Depending on which parts of the spec are broken, I might be okay moving forward with their implementations.
If they do not support the spec, we should rewrite the sim code (probably from mostly from scratch) to take advantage of their simulation APIs (see MockedCANCoder). These should be less-prone to change and (when they do change), those changes should actually be documented, giving us fewer headaches when upgrading.