refactor code #282
Open
refactor code #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR performs code refactoring focused on simplifying NPU operations and improving code quality in the Ascend backend implementation.
- Simplified attention mask generation and removed unnecessary type conversions
- Cleaned up function call signatures by using keyword arguments instead of excessive positional parameters
- Fixed a bug where the graph capturing flag wasn't properly reset
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dlinfer/vendor/ascend/torch_npu_ops.py | Refactored attention operations to remove unnecessary type conversions, simplified mask generation logic, and cleaned up API calls by using keyword arguments |
| dlinfer/framework/lmdeploy_ext/cudagraph/ascend_cudagraph.py | Changed kv_start_indices buffer dtype from int64 to int32 for consistency, and fixed bug by properly resetting the capturing flag after graph capture |
| .github/workflows/main.yml | Updated CI workflow to use DeepLink-org fork and refactor_code branch for testing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.