-
Notifications
You must be signed in to change notification settings - Fork 22
Open
Description
Discussing with @abailoni to get rid of undirectedLongRangeGridGraph because the functionality is almost fully present in undirectedGridGraph.
What's still missing:
- https://github.com/constantinpape/nifty/blob/master/src/python/lib/graph/undirected_long_range_grid_graph.cxx#L102
- https://github.com/constantinpape/nifty/blob/master/src/python/lib/graph/undirected_long_range_grid_graph.cxx#L107 (might not be necessary because it's only a reshape?)
- Support for the edge_mask (https://github.com/constantinpape/nifty/blob/master/src/python/lib/graph/undirected_long_range_grid_graph.cxx#L54), this should be implemented via another overload of
gridRag...Featureswhich take the mask. Will need a quite change to the sampler (should take the edge coordinate instead of the node coordinate). Also it might be necessary to also pass the mask to theprojectEdgeIDsfunction. Not sure yet.
We could then also remove this https://github.com/constantinpape/nifty/blob/46dd374671ec3d517897a68077c3d49a7096ea33/src/python/module/nifty/graph/__init__.py#L120 and refactor the edge mask functionality somewhere else.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels