Skip to content

Commit 388ce98

Browse files
committed
Better capture validation errors
1 parent db41f30 commit 388ce98

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

api/routes/update.ts

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -260,12 +260,13 @@ function validateUpdates(
260260
};
261261
}
262262
if (result.status !== 'Success') {
263-
captureMessage(`update ${update.action} failed validation`, {
263+
captureMessage(`update ${update.action} failed validation: ${result.message}`, {
264264
extra: {
265265
update,
266266
result,
267267
platformMembershipId,
268268
appId,
269+
dimVersion: req.headers['x-dim-version']?.[0],
269270
},
270271
});
271272
console.log('Stately failed update', update.action, result, appId);
@@ -572,12 +573,6 @@ export function validateLoadout(metricPrefix: string, loadout: Loadout, appId: s
572573
}
573574
if ([...loadout.equipped, ...loadout.unequipped].some((i) => i.id && !isValidItemId(i.id))) {
574575
metrics.increment(`${metricPrefix}.validation.itemIdFormat.count`);
575-
captureMessage('item ID is not in the right format', {
576-
extra: {
577-
loadout,
578-
appId,
579-
},
580-
});
581576
return {
582577
status: 'InvalidArgument',
583578
message: 'Item ID is invalid',

0 commit comments

Comments
 (0)