Skip to content

Commit 194ed07

Browse files
authored
fix(web): improve make_bridge! macro hygiene (#777)
There was still some room for improvement.
1 parent 24e64d7 commit 194ed07

File tree

5 files changed

+131
-59
lines changed

5 files changed

+131
-59
lines changed

crates/iron-remote-desktop/src/clipboard.rs

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,20 @@ pub trait ClipboardData {
44
type Item: ClipboardItem;
55

66
fn create() -> Self;
7+
78
fn add_text(&mut self, mime_type: &str, text: &str);
9+
810
fn add_binary(&mut self, mime_type: &str, binary: &[u8]);
11+
912
fn items(&self) -> &[Self::Item];
13+
14+
fn is_empty(&self) -> bool {
15+
self.items().is_empty()
16+
}
1017
}
1118

1219
pub trait ClipboardItem {
1320
fn mime_type(&self) -> &str;
21+
1422
fn value(&self) -> impl Into<JsValue>;
1523
}

crates/iron-remote-desktop/src/error.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ use wasm_bindgen::prelude::*;
22

33
pub trait IronError {
44
fn backtrace(&self) -> String;
5+
56
fn kind(&self) -> IronErrorKind;
67
}
78

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,25 @@
11
pub trait DeviceEvent {
22
fn mouse_button_pressed(button: u8) -> Self;
3+
34
fn mouse_button_released(button: u8) -> Self;
5+
46
fn mouse_move(x: u16, y: u16) -> Self;
7+
58
fn wheel_rotations(vertical: bool, rotation_units: i16) -> Self;
9+
610
fn key_pressed(scancode: u16) -> Self;
11+
712
fn key_released(scancode: u16) -> Self;
13+
814
fn unicode_pressed(unicode: char) -> Self;
15+
916
fn unicode_released(unicode: char) -> Self;
1017
}
1118

1219
pub trait InputTransaction {
1320
type DeviceEvent: DeviceEvent;
1421

1522
fn create() -> Self;
23+
1624
fn add_event(&mut self, event: Self::DeviceEvent);
1725
}

0 commit comments

Comments
 (0)