Remove promote and truncate comment about specialization

kevyuu · kevyuu · commit d7bd053e5c12 · 2025-11-28T17:10:57.000+07:00
diff --git a/include/nbl/builtin/hlsl/cpp_compat/promote.hlsl b/include/nbl/builtin/hlsl/cpp_compat/promote.hlsl
@@ -67,7 +67,6 @@ struct Promote<vector <Scalar, 4>, U>
 
 }
 
-// TODO(kevinyu): Should we specialize this for vector and scalar to take argument by value instead of reference?
 template<typename T, typename U>
 NBL_CONSTEXPR_FUNC T promote(NBL_CONST_REF_ARG(U) v)
 {
diff --git a/include/nbl/builtin/hlsl/cpp_compat/truncate.hlsl b/include/nbl/builtin/hlsl/cpp_compat/truncate.hlsl
@@ -63,7 +63,6 @@ struct Truncate<vector<Scalar, 4>, vector<Scalar, N> NBL_PARTIAL_REQ_BOT(concept
 
 } //namespace impl
 
-// TODO(kevinyu): Should we specialize this for vector and scalar to take argument by value instead of reference?
 template<typename T, typename U>
 NBL_CONSTEXPR_FUNC T truncate(NBL_CONST_REF_ARG(U) v)
 {

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,6 @@ struct Promote<vector <Scalar, 4>, U>`
`67`	`67`
`68`	`68`	`}`
`69`	`69`
`70`		`-// TODO(kevinyu): Should we specialize this for vector and scalar to take argument by value instead of reference?`
`71`	`70`	`template<typename T, typename U>`
`72`	`71`	`NBL_CONSTEXPR_FUNC T promote(NBL_CONST_REF_ARG(U) v)`
`73`	`72`	`{`
Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,6 @@ struct Truncate<vector<Scalar, 4>, vector<Scalar, N> NBL_PARTIAL_REQ_BOT(concept`
`63`	`63`
`64`	`64`	`} //namespace impl`
`65`	`65`
`66`		`-// TODO(kevinyu): Should we specialize this for vector and scalar to take argument by value instead of reference?`
`67`	`66`	`template<typename T, typename U>`
`68`	`67`	`NBL_CONSTEXPR_FUNC T truncate(NBL_CONST_REF_ARG(U) v)`
`69`	`68`	`{`