fix: redundant imports

Author: cassymyo-spec

README.md

@@ -153,11 +153,11 @@ Fiscguy provides the following REST API endpoints:
 
 #### Example API Requests
 
-**Open a Fiscal Day:**
-```bash
-curl -X POST http://localhost:8000/api/open_day/ \
-  -H "Content-Type: application/json"
-```
+## Notes on Credit and Debit Notes
+
+- A person can also submit a credit note.
+- Debit notes are not mandatory.
+- A credit note can have negative values.
 
 **Submit a Receipt:**
 ```bash
@@ -179,6 +179,32 @@ curl -X POST http://localhost:8000/api/receipts/ \
   }'
 ```
 
+**Submit a Credit Note:**
+```bash
+curl -X POST http://localhost:8000/api/receipts/ \
+  -H "Content-Type: application/json" \
+  -d '{
+    "receipt_type": "creditnote",
+    "currency": "USD",
+    "total_amount": "-100.00",
+    "payment_terms": "cash",
+    "lines": [
+      {
+        "product": "Test Item",
+        "quantity": 1,
+        "unit_price": "-100.00",
+        "tax_name": "standard rated 15.5%"
+      }
+    ]
+  }'
+```
+
+**Open a Fiscal Day:**
+```bash
+curl -X POST http://localhost:8000/api/open_day/ \
+  -H "Content-Type: application/json"
+```
+
 **Get Device Status:**
 ```bash
 curl -X GET http://localhost:8000/api/status/ \

fiscguy/management/commands/init_device.py

@@ -6,7 +6,7 @@
 from django.db import transaction
 from loguru import logger
 
-from fiscguy.models import Certs, Configuration, Device, Taxes
+from fiscguy.models import Certs, Device, Taxes
 from fiscguy.zimra_crypto import ZIMRACrypto
 from fiscguy.services.configuration_service import create_or_update_config
 
@@ -275,8 +275,6 @@ def get_config(
         cert_path = temp_dir / "client_cert.pem"
         key_path = temp_dir / "client_key.pem"
 
-        from fiscguy.models import Certs
-
         cert = Certs.objects.first()
         cert_path.write_text(cert.certificate)
         key_path.write_text(cert.certificate_key)
@@ -291,9 +289,10 @@ def get_config(
             response.raise_for_status()
             res = response.json()
 
+            # config business
             create_or_update_config(res)
+
             logger.info(f"Configuration for device {device_id} updated successfully.")
-            return res
         except requests.RequestException as e:
             logger.error(f"Error fetching config: {e}")
             return None
@@ -311,9 +310,8 @@ def register_device(
             if env
             else f"https://fdmsapitest.zimra.co.zw/Public/v1/{device_id}"
         )
-        print(csr)
-        csr = csr.replace("\n", "")
-        print(csr)
+
+        csr = csr.replace("\n", "") # remove newline escape charaters
 
         payload = {
             "activationKey": activation_key,
@@ -338,8 +336,6 @@ def register_device(
             signed_certificate = response.json().get("certificate")
 
             if signed_certificate:
-                from fiscguy.models import Certs
-
                 cert = Certs.objects.first()
                 cert.certificate = signed_certificate
                 cert.save()

fiscguy/zimra_crypto.py

@@ -271,7 +271,7 @@ def generate_key_and_csr(device_sn: str, device_id: int, env: bool = True):
         csr_request = crypto.X509Req()
         subject = csr_request.get_subject()
 
-        # Subject fields (ZIMRA style)
+        # Subject fields ZIMRA way
         subject.C = "ZW"
         subject.ST = "Zimbabwe"
         subject.L = "Harare"