-
Notifications
You must be signed in to change notification settings - Fork 66
Description
Building Gadgets version
3.8.4 build 25
Minecraft Version
1.16.5
Forge Version
36.2.35
Modpack & Version
Sky Capsule Project 1.0.4
Do you have optifine installed?
No
Describe the issue
Multiple copy-paste gadgets share settings
Steps to reproduce
Quick note: I updated building gadgets from the version in the pack, to the latest for 1.16.5.
I'm building a large modular base and using the copy-paste gadget to hold multiple templates (anviled to keep them straight). But I'm having to jump through a hoop.
If I craft more than one c&p gadget, they are entangled, so that editing the template on one edits the others. It doesn't matter how I craft them- via automation, or on a plain crafting table. Each gadget maintains SOME of its own settings, like whether it's in Copy or Paste mode, and the bounds of the current copy region. But the actual template is shared. Imagine I crafted two, CPA and CPB.
Highlighting an area on EITHER CPA or CPB will save the template to BOTH CPA and CPB.
Using the template manager to load a new template into either CPA or CPB (either from a template item or clipboard) will update both (and all other entangled gadgets), including the name.
Crafting a third gadget now will create CPC, which ALSO, already, has that template assigned. Holding shift on the unfinished crafting product on a crafting table will even show the template's materials.
Reloading the save, or using kubejs's /reload, will reset this behavior temporarily, allowing me to craft a "fresh" unentangled gadget, though any further ones will be entangled with that one.
I can get two other "fresh" gadgets, per reload, by using jei's cheat mode to take both the empty and the full gadget one out of JEI. If I use them to copy an area, I'll actually see the ones inside JEI show the template, and taking any more will have them be entangled. Reloading refreshes them to properly blank gadgets.
Couple more notes from my debugging:
Stashing the gadgets inside inventories doesn't help, they're still sharing a reference.
Reloading the game does not dis-entangle any already entangled gadgets.
It does not matter if I craft (or cheat in) multiple "blank" gadgets, without using them. If I do, they'll all show blank until I use one, which updates all of them, and further crafted ones will be entangled.
I thought this might be a kubejs custom recipe, written incorrectly, causing one specific gadget to be created and copying its internal tags (especially since this affects JEI). But this pack doesn't seem to alter the gadget's recipe, as far as I can see.
A cursory check doesn't seem to show any relevant NBT data, like some kind of reference ID, being re-used? I might be missing it though
Expected behaviour
Each created copy-paste gadget should start fresh and not entangled with others.
Screenshots
No response
Log files
No response
Additional information
Screenshots don't exactly capture the issue, and I don't see anything relevant in logs, but I can screen record if somehow it's not reproduceable.
Information
- I have provided as much information as possible