From b67505fe2d6775e4eaa5f7551105c099c1566425 Mon Sep 17 00:00:00 2001 From: robertomarcos-diverger Date: Tue, 25 Nov 2025 19:36:52 +0100 Subject: [PATCH] Fix SonarQube issues in src/codeas/ui/components/repo_ui.py --- src/codeas/ui/components/repo_ui.py | 50 ++++++++++++++++------------- 1 file changed, 28 insertions(+), 22 deletions(-) diff --git a/src/codeas/ui/components/repo_ui.py b/src/codeas/ui/components/repo_ui.py index 1261c37..766b577 100644 --- a/src/codeas/ui/components/repo_ui.py +++ b/src/codeas/ui/components/repo_ui.py @@ -6,6 +6,12 @@ from codeas.core.state import state +# Define constants for duplicated literals +INCLUDE_COLUMN_KEY = "Incl." +PATH_COLUMN_KEY = "Path" +TOKENS_COLUMN_KEY = "Tokens" + + def display(): display_repo_path() display_files() @@ -25,11 +31,11 @@ def display_files(): def get_selected_files_info(): - num_selected_files = sum(state.files_data["Incl."]) - total_files = len(state.files_data["Incl."]) + num_selected_files = sum(state.files_data[INCLUDE_COLUMN_KEY]) + total_files = len(state.files_data[INCLUDE_COLUMN_KEY]) selected_tokens = sum( token - for incl, token in zip(state.files_data["Incl."], state.files_data["Tokens"]) + for incl, token in zip(state.files_data[INCLUDE_COLUMN_KEY], state.files_data[TOKENS_COLUMN_KEY]) if incl ) return num_selected_files, total_files, selected_tokens @@ -68,9 +74,9 @@ def display_files_editor(): state.files_data, use_container_width=True, column_config={ - "Incl.": st.column_config.CheckboxColumn(width=5), - "Path": st.column_config.TextColumn(width="large"), - "Tokens": st.column_config.NumberColumn(width=5), + INCLUDE_COLUMN_KEY: st.column_config.CheckboxColumn(width=5), + PATH_COLUMN_KEY: st.column_config.TextColumn(width="large"), + TOKENS_COLUMN_KEY: st.column_config.NumberColumn(width=5), }, disabled=True, height=300, @@ -83,9 +89,9 @@ def display_metadata_editor(files_metadata): files_metadata, use_container_width=True, column_config={ - "Incl.": st.column_config.CheckboxColumn(width=5), - "Path": st.column_config.TextColumn(width="large"), - "Tokens": st.column_config.NumberColumn(width=5), + INCLUDE_COLUMN_KEY: st.column_config.CheckboxColumn(width=5), + PATH_COLUMN_KEY: st.column_config.TextColumn(width="large"), + TOKENS_COLUMN_KEY: st.column_config.NumberColumn(width=5), }, disabled=True, height=300, @@ -95,30 +101,30 @@ def display_metadata_editor(files_metadata): def sort_files_data(): sorted_data = sorted( zip( - state.files_data["Incl."], - state.files_data["Path"], - state.files_data["Tokens"], + state.files_data[INCLUDE_COLUMN_KEY], + state.files_data[PATH_COLUMN_KEY], + state.files_data[TOKENS_COLUMN_KEY], ), key=lambda x: (not x[0], x[1]), ) ( - state.files_data["Incl."], - state.files_data["Path"], - state.files_data["Tokens"], + state.files_data[INCLUDE_COLUMN_KEY], + state.files_data[PATH_COLUMN_KEY], + state.files_data[TOKENS_COLUMN_KEY], ) = zip(*sorted_data) def sort_files_metadata(files_metadata): sorted_data = sorted( zip( - files_metadata["Incl."], - files_metadata["Path"], - files_metadata["Tokens"], + files_metadata[INCLUDE_COLUMN_KEY], + files_metadata[PATH_COLUMN_KEY], + files_metadata[TOKENS_COLUMN_KEY], ), key=lambda x: (not x[0], x[1]), ) ( - files_metadata["Incl."], - files_metadata["Path"], - files_metadata["Tokens"], - ) = zip(*sorted_data) + files_metadata[INCLUDE_COLUMN_KEY], + files_metadata[PATH_COLUMN_KEY], + files_metadata[TOKENS_COLUMN_KEY], + ) = zip(*sorted_data) \ No newline at end of file