Skip to content

feat (pattern-editor): allow for copying single row when no selection is available #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat (pattern-editor): allow for copying single row when no selection is available #385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc33534
feat: allow for copying without a selection (copies single line)
henrikvilhelmberglund Oct 16, 2025
36ff7db
feat: copy single row when not selecting anything
henrikvilhelmberglund Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions Source/MainFrm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2496,8 +2496,21 @@ void CMainFrame::OnUpdateEditCut(CCmdUI *pCmdUI)

void CMainFrame::OnUpdateEditCopy(CCmdUI *pCmdUI)
{
CFamiTrackerView *pView = static_cast<CFamiTrackerView*>(GetActiveView());
pCmdUI->Enable((pView->IsSelecting() || GetFocus() == m_pFrameEditor) ? 1 : 0);
CFamiTrackerView *pView = static_cast<CFamiTrackerView*>(GetActiveView());
bool patternEditorFocused = (GetFocus() == pView);
bool hasSelection = pView->IsSelecting();

// Check if the cursor is on a valid cell in the pattern editor
bool cursorValid = false;
if (patternEditorFocused) {
auto *pEditor = pView->GetPatternEditor();
const auto &cursor = pEditor->GetCursor();
int frameLen = pEditor->GetCurrentPatternLength(cursor.m_iFrame);
int channelCount = static_cast<CFamiTrackerDoc*>(GetActiveDocument())->GetAvailableChannels();
cursorValid = cursor.IsValid(frameLen, channelCount);
}

pCmdUI->Enable(hasSelection || cursorValid);
}

void CMainFrame::OnUpdatePatternEditorSelected(CCmdUI *pCmdUI) // // //
Expand Down
69 changes: 44 additions & 25 deletions Source/PatternEditor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3537,32 +3537,51 @@ CPatternClipData *CPatternEditor::CopyEntire() const

CPatternClipData *CPatternEditor::Copy() const
{
// Copy selection
CPatternIterator it = GetIterators().first; // // //
const int Channels = m_selection.GetChanEnd() - m_selection.GetChanStart() + 1;
const int Rows = GetSelectionSize(); // // //
stChanNote NoteData;

CPatternClipData *pClipData = new CPatternClipData(Channels, Rows);
pClipData->ClipInfo.Channels = Channels; // // //
pClipData->ClipInfo.Rows = Rows;
pClipData->ClipInfo.StartColumn = GetSelectColumn(m_selection.GetColStart()); // // //
pClipData->ClipInfo.EndColumn = GetSelectColumn(m_selection.GetColEnd()); // // //

for (int r = 0; r < Rows; r++) { // // //
for (int i = 0; i < Channels; ++i) {
stChanNote *Target = pClipData->GetPattern(i, r);
it.Get(i + m_selection.GetChanStart(), &NoteData);
/*CopyNoteSection(Target, &NoteData, PASTE_DEFAULT,
// Copy selection if selecting
if (m_bSelecting && GetSelectionSize() > 0) {
CPatternIterator it = GetIterators().first; // // //
const int Channels = m_selection.GetChanEnd() - m_selection.GetChanStart() + 1;
const int Rows = GetSelectionSize(); // // //
stChanNote NoteData;

CPatternClipData *pClipData = new CPatternClipData(Channels, Rows);
pClipData->ClipInfo.Channels = Channels; // // //
pClipData->ClipInfo.Rows = Rows;
pClipData->ClipInfo.StartColumn = GetSelectColumn(m_selection.GetColStart()); // // //
pClipData->ClipInfo.EndColumn = GetSelectColumn(m_selection.GetColEnd()); // // //

for (int r = 0; r < Rows; r++) { // // //
for (int i = 0; i < Channels; ++i) {
stChanNote *Target = pClipData->GetPattern(i, r);
it.Get(i + m_selection.GetChanStart(), &NoteData);
/*CopyNoteSection(Target, &NoteData, PASTE_DEFAULT,
i == 0 ? ColStart : COLUMN_NOTE, i == Channels - 1 ? ColEnd : COLUMN_EFF4);*/
memcpy(Target, &NoteData, sizeof(stChanNote));
// the clip data should store the entire field;
// other methods should check ClipInfo.StartColumn and ClipInfo.EndColumn before operating
}
++it;
}

return pClipData;
memcpy(Target, &NoteData, sizeof(stChanNote));
// the clip data should store the entire field;
// other methods should check ClipInfo.StartColumn and ClipInfo.EndColumn before operating
}
++it;
}
return pClipData;
}

// If nothing is selected, copy the row under the cursor
const int Track = GetSelectedTrack();
const int Channel = m_cpCursorPos.m_iChannel;
const int Row = m_cpCursorPos.m_iRow;
const int Frame = m_cpCursorPos.m_iFrame;
const cursor_column_t Col = m_cpCursorPos.m_iColumn;

CPatternClipData *pSingleNote = new CPatternClipData(1, 1);
pSingleNote->ClipInfo.Channels = 1;
pSingleNote->ClipInfo.Rows = 1;

// Always copy note, instrument, volume, and all 4 effects
pSingleNote->ClipInfo.StartColumn = static_cast<column_t>(C_NOTE);
pSingleNote->ClipInfo.EndColumn = static_cast<column_t>(C_EFF4_PARAM2);

m_pDocument->GetNoteData(Track, Frame, Channel, Row, pSingleNote->GetPattern(0, 0));
return pSingleNote;
}

CPatternClipData *CPatternEditor::CopyRaw() const // // //
Expand Down