Skip to content

formatting #20

@pawrequest

Description

@pawrequest

you graciously accepted some PRs, and so i have confidence it's worth contributing where i can, but i use code-formatting (ruff) which runs every time i save or even run code, which causes a ton of spurious changes to merge (specifically there's a load of unnecessary whitespace in the files)

any formatter (but ruff, always ruff it's super-fast) will remove random whitespace at the ends of lines, and excess blank lines between funcs and classes, which would remove most of the spurious changes i'm having to surgically remove before submitting PRs.

https://docs.astral.sh/ruff/formatter/

to go further we could to define a style guide including things like preferencing either single or double quotes, max line length, and other minor points, although it may be best to just use default settings.

creating a style guide is as simple as adding a section to the pyproject.toml file, although it doesn't look like you want to merge the PR for using pyproject format?

sorry if this is obvious, but having pyproject format makes it super easy for users to use the package - they can just pip install -e . from within the repo root, and they get all the dependencies (ie pillow, and anything else that gets added).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions