|
LR_GiveNormalItemA8OrSec: |
The whole give-item infrastructure made sense when introduced, but has become difficult as more features were added; see e.g. the new complexity required for the A16 routine to pass an 8-bit item ID >= $87 into A8, set $0db8 correctly, and pass the correct value to MaybeLogTimeOfItemGet. Perhaps should refactor this to just one A16 routine that takes carry as a parameter to mean silent/nonsilent, and update callers appropriately.
IoGR/src/iog_randomizer/randomizer/iogr_code_overflow.asr
Line 61 in 3054dfd
The whole give-item infrastructure made sense when introduced, but has become difficult as more features were added; see e.g. the new complexity required for the A16 routine to pass an 8-bit item ID >= $87 into A8, set $0db8 correctly, and pass the correct value to MaybeLogTimeOfItemGet. Perhaps should refactor this to just one A16 routine that takes carry as a parameter to mean silent/nonsilent, and update callers appropriately.