Skip to content

Commit a5bef26

Browse files
committed
remove test as the warning is not expected anymore
1 parent ba1c51f commit a5bef26

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

doubleml/tests/test_exceptions.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -986,7 +986,6 @@ def predict(self, X):
986986
@pytest.mark.ci
987987
def test_doubleml_exception_learner():
988988
err_msg_prefix = "Invalid learner provided for ml_l: "
989-
warn_msg_prefix = "Learner provided for ml_l is probably invalid: "
990989

991990
msg = err_msg_prefix + "provide an instance of a learner instead of a class."
992991
with pytest.raises(TypeError, match=msg):
@@ -1005,12 +1004,6 @@ def test_doubleml_exception_learner():
10051004
with pytest.warns(UserWarning):
10061005
_ = DoubleMLIRM(dml_data_irm, Lasso(), _DummyNoClassifier())
10071006

1008-
# ToDo: Currently for ml_l (and others) we only check whether the learner can be identified as regressor. However,
1009-
# we do not check whether it can instead be identified as classifier, which could be used to throw an error.
1010-
msg = warn_msg_prefix + r"LogisticRegression\(\) is \(probably\) no regressor."
1011-
with pytest.warns(UserWarning, match=msg):
1012-
_ = DoubleMLPLR(dml_data, LogisticRegression(), Lasso())
1013-
10141007
# we allow classifiers for ml_m in PLR, but only for binary treatment variables
10151008
msg = (
10161009
r"The ml_m learner LogisticRegression\(\) was identified as classifier "

0 commit comments

Comments
 (0)