Skip to content

Feedback #16

@case-eee

Description

@case-eee
  • It might be nice to have all the endpoints listed on the root of your api; that way if someone is hitting your api on production - they'll know how it works
  • I suggest adding a README to your backend 👍
  • Be mindful of making your API routes restful - for example, /api/foods/edit/:name doesn't follow RESTful conventions. I think it's fine to use name instead of id (if you're sure name is a unique value), but it should be /api/foods/:name/edit if we want to follow convention.
  • Fantastic job refactoring your node backend. It looks really really solid 👍
  • I suggest updating the README for your frontend to match what the code does!
  • Be sure to follow naming conventions for naming files in your frontend (they should probably be camel case since we're working with JS)
  • I love that y'all got to some ajax. I suggest keep practicing with it. You could even extract out the ajax calls into smaller functions. I'd remove all console.log's from your code before pushing it up. As far as your POST ajax request goes, I think you should probably add the new food to the page upon a successful return rather than just console.log-ing the response.

Great work with this 🎉 It sounds like y'all deepened your knowledge with JavaScript and were able to implement the new material AND refactor. It seems like you for sure accomplished your goals with this. I hope you'll take what you've learned and continue to dive deeper 👍

@DavidKnott @Dpalazzari

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions