In the process of creating:
E3SM-Project/PhysicalConstantsDictionary#17
Copilot pointed out that Omega's speed of sound in seawater is off by a factor of 10:
|
constexpr Real Sound = 1.5e2; // Speed of sound ~ m/s |
It should be 1500 m/s, not 150.
There are some other small differences between the values of constants in shr_const_mod.F90 and in GlobalConstants.h. In most (all?) cases, I have chosen to stick with shr_const_mod.F90 over GlobalConstants.h when updating the Physical Constants Dictionary because I think we have to make a case for why those values need to be updated that the rest of the development team should be able to respond to.
In the process of creating:
E3SM-Project/PhysicalConstantsDictionary#17
Copilot pointed out that Omega's speed of sound in seawater is off by a factor of 10:
Omega/components/omega/src/ocn/GlobalConstants.h
Line 68 in e6e7b09
It should be 1500 m/s, not 150.
There are some other small differences between the values of constants in shr_const_mod.F90 and in
GlobalConstants.h. In most (all?) cases, I have chosen to stick withshr_const_mod.F90overGlobalConstants.hwhen updating the Physical Constants Dictionary because I think we have to make a case for why those values need to be updated that the rest of the development team should be able to respond to.