You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the PR #460 I just opened, I noticed that the elastic-miter README.md hadn't been reviewed.
This raised a broader concern for me about the current review process in Dynamatic. I've noticed that some recent PRs were merged very quickly, sometimes without any suggestions like #449, even though they involved a significant amount of code.
This can lead to issues for users later on. I actually ran into trouble with the unreviewed README.md.
That said, I'm not suggesting we formalize the review process or slow things down. I value the flexibility and speed we have.
So, what if we agree on one principle?
If you approve a PR, you have the responsibility to explain how the code works and why the design choices were made. (including documents or other build files)
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
In the PR #460 I just opened, I noticed that the elastic-miter README.md hadn't been reviewed.
This raised a broader concern for me about the current review process in Dynamatic. I've noticed that some recent PRs were merged very quickly, sometimes without any suggestions like #449, even though they involved a significant amount of code.
This can lead to issues for users later on. I actually ran into trouble with the unreviewed README.md.
That said, I'm not suggesting we formalize the review process or slow things down. I value the flexibility and speed we have.
So, what if we agree on one principle?
If you approve a PR, you have the responsibility to explain how the code works and why the design choices were made. (including documents or other build files)
Would people be on board with that?
@murphe67 @Jiahui17 @Carmine50 @AyaElAkhras @schilkp
Beta Was this translation helpful? Give feedback.
All reactions