fix: enhanced error handling

Author: ESnark

.changeset/cute-bikes-show.md

@@ -0,0 +1,5 @@
+---
+"ansible-database-mcp": patch
+---
+
+enhanced error handling

src/main.ts

@@ -15,8 +15,23 @@ const authStrategy = await initializeAuth();
 const app = express();
 const PORT = process.env.PORT || 3000;
 
-// JSON parsing middleware
-app.use(express.json());
+// JSON parsing middleware with error handling
+app.use(express.json({ limit: '10mb' }));
+
+// JSON parsing error handler
+app.use((err: any, req: express.Request, res: express.Response, next: express.NextFunction) => {
+  if (err instanceof SyntaxError && 'body' in err) {
+    return res.status(400).json({
+      jsonrpc: '2.0',
+      error: {
+        code: -32700, // Parse error in JSON-RPC
+        message: 'Invalid JSON syntax: ' + err.message
+      },
+      id: null
+    });
+  }
+  next(err);
+});
 
 // CORS middleware
 app.use(cors({

src/services/db-connection/adapters/databricks-adapter.ts

@@ -73,8 +73,9 @@ export class DatabricksAdapter extends EventEmitter {
       for (let i = 0; i < this.poolSize.min; i++) {
         await this.createSession();
       }
-    } catch (error) {
-      throw new Error(`Failed to initialize Databricks connection: ${error}`);
+    } catch (error: any) {
+      console.error('[Databricks] Connection error:', error);
+      throw error;
     }
   }
 
@@ -87,15 +88,21 @@ export class DatabricksAdapter extends EventEmitter {
     }
 
     const connection = this.config.connection as any;
-    const session = await this.client.openSession({
-      initialCatalog: connection.catalog,
-      initialSchema: connection.database  // database field is used as schema in Databricks
-    });
-
-    this.sessions.push(session);
-    this.availableSessions.push(session);
 
-    return session;
+    try {
+      const session = await this.client.openSession({
+        initialCatalog: connection.catalog,
+        initialSchema: connection.database  // database field is used as schema in Databricks
+      });
+
+      this.sessions.push(session);
+      this.availableSessions.push(session);
+      
+      return session;
+    } catch (error: any) {
+      console.error('[Databricks] Session creation error:', error);
+      throw error;
+    }
   }
 
   /**
@@ -177,6 +184,9 @@ export class DatabricksAdapter extends EventEmitter {
         rows: result,
         fields
       };
+    } catch (error: any) {
+      console.error('[Databricks] Query execution error:', error);
+      throw error;
     } finally {
       this.releaseSession(session);
     }

src/services/query.ts

@@ -88,10 +88,17 @@ export async function executeQuery(dbKey: string, params: QueryParams): Promise<
     logError('Query execution error', error);
     logQuery(query, params, executionTime, false, error.message);
 
+    // Return full error details for better debugging
     return {
       success: false,
-      error: error.message,
-      message: 'An error occurred while executing the query.'
+      error: error.message || 'Unknown error',
+      message: error.stack || 'An error occurred while executing the query.',
+      details: {
+        code: error.code,
+        statusCode: error.statusCode,
+        sqlState: error.sqlState,
+        originalError: error.toString()
+      }
     };
   } finally {
     // Return connection

src/tools/query.ts

@@ -56,16 +56,23 @@ const handler: ToolCallback<typeof definition.inputSchema> = async (args) => {
         ],
       };
     } else {
-      // Format the error result
+      // Format the error result with full details
+      const errorResponse: any = {
+        success: false,
+        error: result.error || 'Unknown error occurred',
+        message: result.message || 'Query execution failed',
+      };
+      
+      // Include details if available
+      if (result.details) {
+        errorResponse.details = result.details;
+      }
+      
       return {
         content: [
           {
             type: 'text',
-            text: JSON.stringify({
-              success: false,
-              error: result.error || 'Unknown error occurred',
-              message: result.message || 'Query execution failed',
-            }, null, 2),
+            text: JSON.stringify(errorResponse, null, 2),
           },
         ],
       };

src/types/index.ts

@@ -17,6 +17,7 @@ export interface APIResponse<T = any> {
   data?: T;
   error?: string;
   message?: string;
+  details?: any;
 }
 
 export interface QueryResult {