"ISO15118 Extension interface mapping not set! Not sending 'ChargingNeeds'!"

[Abby-Wheelis]

Describe the bug
When additional logging is added, EVerest breaks and charging fails.

To Reproduce
Steps to reproduce the behavior:

1. Run 1-line demo curl https://raw.githubusercontent.com/everest/everest-demo/main/demo-iso15118-2-ocpp-201.sh | bash -s -- -1
2. Use UI to execute a basic charging session (set simulation, plugin, swipe RFID)
3. Note successful charging session
4. Add logging and attempt charging session
5. Encounter race condition with Slac Matching
6. Patch race condition with Slac Matching, attempt charging session
7. Encounter error: [WARN] ocpp:OCPP201 module::OCPP201::ready()::<lambda(const types::iso15118::ChargingNeeds&)> :: ISO15118 Extension interface mapping not set! Not sending 'ChargingNeeds'! and a hang when waiting for CAR ISO AC HLC Close contactor

Expected behavior
Charging should proceed as it does without the logging.

Setup (please complete the following information):

• Software in the loop with EVerest Demo (1-line for working, dev containers for added logging)

Desktop (please complete the following information):

• Docker Desktop 4.38.0
• Docker Engine: 27.5.1
• Docker Compose: v2.32.4-desktop.1

Additional context
See issue for additional tracking: 151
Patches in the issue -- will add more later today!

[mlitre]

Hi @Abby-Wheelis you are missing the mapping field for the iso15118_charger module in your config. If you add that you should not have any issues anymore. You can see this done for the evse manager already.
Let me know if this fixes your issue

[Abby-Wheelis]

I added it to the config file and that error went away, unfortunately the charging still times out while waiting for AR ISO AC HLC Close contactor. I will keep investigating and check back in if I discover the precise error.

It is worth noting that adding the logging did highlight a race condition, which I fixed below:

Original:

bool CarSimulation::iso_wait_slac_matched(const CmdArguments& arguments) {
    sim_data.state = SimState::PLUGGED_IN;

    if (sim_data.slac_state == "UNMATCHED") {
        EVLOG_debug << "Slac UNMATCHED";
        if (!r_slac.empty()) {
            EVLOG_debug << "Slac trigger matching";
            r_slac[0]->call_reset();
            r_slac[0]->call_trigger_matching();
            sim_data.slac_state = "TRIGGERED"; //setting to "triggered" -- but sometimes had already been matched and thus hung (race condition)
        }
    }
    if (sim_data.slac_state == "MATCHED") {
        EVLOG_debug << "Slac Matched";
        return true;
    }
    return false;
}

Resolved:

bool CarSimulation::iso_wait_slac_matched(const CmdArguments& arguments) {
    sim_data.state = SimState::PLUGGED_IN;

    if (sim_data.slac_state == "UNMATCHED") {
        if (!r_slac.empty()) {
            r_slac[0]->call_reset();
            r_slac[0]->call_trigger_matching();
            EVLOG_info << "After trigger matching call, state is " << sim_data.slac_state;
            if (sim_data.slac_state == "MATCHING") {
                EVLOG_debug << "Slac Matched already, skipping 'TRIGGERED'";
                return true;
            }
            else {
                sim_data.slac_state = "TRIGGERED";
            }
        } 
    }
    if (sim_data.slac_state == "MATCHED") {
        EVLOG_debug << "Slac Matched";
        return true;
    }
    return false;
}

[Abby-Wheelis]

To see issues with race conditions:

Run 1-line demo: curl https://raw.githubusercontent.com/everest/everest-demo/main/demo-iso15118-2-ocpp-201.sh | bash -s -- -1
Start a charging session with nodered UI, see successful charging.

Apply these patches: break_matching.patch

See charging get stuck in slac matching because state moves to "MATCHING" and then is overridden to "TRIGGERED"

Make the changes in the above comment

Charging no longer gets stuck.

This race condition came up when we were adding logging to debug another issue. Has anyone else encountered this problem? Are there any other similar issues we should be aware of where adding logging will break charging?