Add step to remove support containers

Author: sagarnasit

migrations/container/20181225063950_service-command_change_global_service_container_names.php

@@ -46,7 +46,6 @@ public function up() {
 			}
 		}
 
-
 		/**
 		 * Backup old docker-compose file.
 		 */
@@ -95,26 +94,26 @@ public function up() {
 		 * Start nginx-proxy container.
 		 */
 		self::$rsp->add_step(
-			'start-nginx-proxy-containers',
-			'EE\Service\Utils\nginx_proxy_check',
+			'start-renamed-containers',
+			'EE\Migration\ChangeGlobalServiceContainerNames::start_global_service_containers',
 			'EE\Migration\ChangeGlobalServiceContainerNames::stop_default_containers',
-			null,
+			[ $running_containers ],
 			null
 		);
 
 		/**
 		 * Start other service containers.
 		 */
 		self::$rsp->add_step(
-			'start-other-service-containers',
-			'EE\Migration\ChangeGlobalServiceContainerNames::start_other_service_containers',
+			'remove-support-containers',
+			'EE\Migration\GlobalContainers::disable_support_containers',
+			null,
 			null,
-			[ $running_containers ],
 			null
 		);
 
 		if ( ! self::$rsp->execute() ) {
-			throw new \Exception( 'Unable run update-index migrations.' );
+			throw new \Exception( 'Unable run change-global-service-container-name migrations.' );
 		}
 
 	}
@@ -127,6 +126,12 @@ public function up() {
 	public function down() {
 	}
 
+	/**
+	 * Restore docker-compose.yml and start old ee-containers.
+	 *
+	 * @param $source string path of source file.
+	 * @param $destination string path of destination.
+	 */
 	public static function restore_yml_file( $source, $destination ) {
 		EE\Migration\SiteContainers::backup_restore( $source, $destination );
 
@@ -135,13 +140,25 @@ public static function restore_yml_file( $source, $destination ) {
 		EE::exec( 'docker-compose up -d' );
 	}
 
+	/**
+	 * Remove running global ee-containers.
+	 *
+	 * @param $containers array of running global containers.
+	 *
+	 * @throws \Exception
+	 */
 	public static function remove_global_ee_containers( $containers ) {
 		$removable_containers = implode( ' ', $containers );
 		if ( ! EE::exec( "docker rm -f $removable_containers" ) ) {
 			throw new \Exception( 'Unable to remove global service containers' );
 		}
 	}
 
+	/**
+	 * Stop default global containers.
+	 *
+	 * @throws \Exception
+	 */
 	public static function stop_default_containers() {
 
 		chdir( EE_SERVICE_DIR );
@@ -151,12 +168,21 @@ public static function stop_default_containers() {
 		}
 	}
 
-	public static function start_other_service_containers( $containers ) {
+	/**
+	 * Start global services with renamed containers names.
+	 *
+	 * @param $containers array of running global containers.
+	 *
+	 * @throws \Exception
+	 */
+	public static function start_global_service_containers( $containers ) {
 
 		foreach ( $containers as $container ) {
 			$service = ltrim( $container, 'ee-' );
 			GlobalContainers::global_service_up( $service );
 		}
 
 	}
+
+
 }