Sanitize or stub safeUrl usage #10
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove safeUrl parameter from BlockbookOptions and EvmRpcOptions interfaces - Add sanitizeUrlForLogging utility function that removes API keys from URLs - Use sanitization function in blockbook plugin (API keys are added to URLs) - Stub sanitization function in evmRpc plugin with TODO (API keys not yet used for RPC URLs) - Remove safeUrl usage from allPlugins.ts
|
Cursor Agent can help with this pull request. Just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Dependencies
none
Description
Replaces the
safeUrlproperty with a dedicatedsanitizeUrlForLoggingutility function to explicitly handle sensitive information in URLs before logging.sanitizeUrlForLoggingfunction: Removes API keys from URL path segments and common query parameters (apikey,api_key,apiKey).sanitizeUrlForLoggingfor logging and metrics, as API keys are appended to their URLs.sanitizeUrlForLoggingis added with a TODO, as API keys are not currently added to RPC URLs. It returns the URL as-is, to be fully implemented when API keys are used for RPC URLs.This change improves security by ensuring API keys are consistently removed from logged URLs where applicable.