QA: Test support for signet as parent chain

Author: jtimon

qa/rpc-tests/feature_fedpeg.py

@@ -34,14 +34,14 @@ def add_options(self, parser):
         parser.add_option("--parent_binpath", dest="parent_binpath", default="",
                           help="Use a different binary for launching nodes")
         parser.add_option("--parent_type", dest="parent_type", default="elements",
-                          help="Type of parent nodes {elements, bitcoin}")
+                          help="Type of parent nodes {elements, bitcoin, signet}")
 
     def setup_network(self, split=False):
         self.nodes = []
         self.extra_args = []
 
-        if self.options.parent_type not in ['elements', 'bitcoin']:
-            raise Exception("Invalid option --parent_type=%s, valid options: elements, bitcoin" % self.options.parent_type)
+        if self.options.parent_type not in ['elements', 'bitcoin', 'signet']:
+            raise Exception("Invalid option --parent_type=%s, valid values: {elements, bitcoin, signet}" % self.options.parent_type)
 
         if self.options.parent_type == 'bitcoin' and self.options.parent_binpath == "":
             raise Exception("Can't run with --parent_type=bitcoin without specifying --parent_binpath")
@@ -60,16 +60,35 @@ def setup_network(self, split=False):
                     "-addresstype=legacy", # To make sure bitcoind gives back p2pkh no matter version
                     "-deprecatedrpc=validateaddress",
                 ])
-            else:
+            elif self.options.parent_type == 'signet':
+                self.parent_chain = 'signet'
+                rpc_u, rpc_p = rpc_auth_pair(n)
+                self.extra_args.append([
+                    "-printtoconsole=0",
+                    "-signet_blockscript=4104db082f6133b7d9cdb7be60d8384c818ae61233c20485b438e8c1d7772b7f2dbdc04f2f7273d534df0e6a54c8b333994f6275bb921df2438e9a672438e4ed4969ac",
+                    "-signet_siglen=77",
+                    "-signet_seednode=178.128.221.177",
+                    "-port=" + str(p2p_port(n)),
+                    "-rpcuser=" + rpc_u,
+                    "-rpcpassword=" + rpc_p,
+                    "-rpcport=" + str(rpc_port(n)),
+                    "-addresstype=legacy", # To make sure bitcoind gives back p2pkh no matter version
+                    "-deprecatedrpc=validateaddress",
+                    "-fallbackfee=0.00001",
+                ])
+            elif self.options.parent_type == 'elements':
                 self.parent_chain = 'parent'
                 self.extra_args.append([
                     "-printtoconsole=0",
                     '-validatepegin=0',
                     '-anyonecanspendaremine',
                     '-initialfreecoins=2100000000000000',
                 ])
+
             self.binary = self.options.parent_binpath if self.options.parent_binpath != "" else None
             self.nodes.append(start_node(n, self.options.tmpdir, self.extra_args[n], binary=self.binary, chain=self.parent_chain))
+            if self.options.parent_type == 'signet':
+                self.nodes[n].importprivkey('8Hh8jNjkx1aSCgEk3iq9Vo2APZUSDQJVt3rJ2BRpb5Tavqb68vW')
 
         connect_nodes_bi(self.nodes, 0, 1)
         self.parentgenesisblockhash = self.nodes[0].getblockhash(0)
@@ -102,6 +121,14 @@ def setup_network(self, split=False):
                     '-con_parent_chain_signblockscript=%s' % parent_chain_signblockscript,
                     '-con_parent_pegged_asset=%s' % parent_pegged_asset,
                 ])
+            elif self.options.parent_type == 'signet':
+                args.extend([
+                    '-con_parent_is_signet=1',
+                    '-con_parent_signet_siglen=77',
+                    '-parentpubkeyprefix=125',
+                    '-parentscriptprefix=87',
+                    '-con_parent_chain_signblockscript=4104db082f6133b7d9cdb7be60d8384c818ae61233c20485b438e8c1d7772b7f2dbdc04f2f7273d534df0e6a54c8b333994f6275bb921df2438e9a672438e4ed4969ac',
+                ])
             self.extra_args.append(args)
             self.nodes.append(start_node(n + 2, self.options.tmpdir, self.extra_args[n + 2], chain='sidechain'))
 
@@ -126,13 +153,21 @@ def test_pegout(self, parent_chain_addr, sidechain):
                 break
         assert pegout_tested
 
+    # TODO Remove when signet supports generate
+    def parent_generate(self, parent, n_blocks):
+        if self.options.parent_type == 'signet':
+            for i in range(0, n_blocks):
+                blockhex = parent.getnewblockhex(True)
+        else:
+            parent.generate(n_blocks)
+
     def run_test(self):
         parent = self.nodes[0]
         parent2 = self.nodes[1]
         sidechain = self.nodes[2]
         sidechain2 = self.nodes[3]
 
-        parent.generate(101)
+        self.parent_generate(parent, 101)
         sidechain.generate(101)
 
         addrs = sidechain.getpeginaddress()
@@ -141,7 +176,7 @@ def run_test(self):
         print(parent.validateaddress(addr))
         txid1 = parent.sendtoaddress(addr, 24)
         # 10+2 confirms required to get into mempool and confirm
-        parent.generate(1)
+        self.parent_generate(parent, 1)
         time.sleep(2)
         proof = parent.gettxoutproof([txid1])
 
@@ -158,7 +193,7 @@ def run_test(self):
             assert("Peg-in Bitcoin transaction needs more confirmations to be sent." in e.error["message"])
 
         # Second attempt simply doesn't hit mempool bar
-        parent.generate(10)
+        self.parent_generate(parent, 10)
         try:
             pegtxid = sidechain.claimpegin(raw, proof)
             raise Exception("Peg-in should not be mature enough yet, need another block.")
@@ -183,7 +218,7 @@ def run_test(self):
             assert("Given claim_script does not match the given Bitcoin transaction." in e.error["message"])
 
         # 12 confirms allows in mempool
-        parent.generate(1)
+        self.parent_generate(parent, 1)
         # Should succeed via wallet lookup for address match, and when given
         pegtxid1 = sidechain.claimpegin(raw, proof)
 
@@ -234,7 +269,7 @@ def run_test(self):
         for i in range(n_claims):
             addrs = sidechain.getpeginaddress()
             txid = parent.sendtoaddress(addrs["mainchain_address"], 1)
-            parent.generate(12)
+            self.parent_generate(parent, 12)
             proof = parent.gettxoutproof([txid])
             raw = parent.getrawtransaction(txid)
             pegtxs += [sidechain.claimpegin(raw, proof)]
@@ -249,11 +284,13 @@ def run_test(self):
         print("Test pegout")
         self.test_pegout(get_new_unconfidential_address(parent), sidechain)
 
-        print("Test pegout P2SH")
-        parent_chain_addr = get_new_unconfidential_address(parent)
-        parent_pubkey = parent.validateaddress(parent_chain_addr)["pubkey"]
-        parent_chain_p2sh_addr = parent.createmultisig(1, [parent_pubkey])["address"]
-        self.test_pegout(parent_chain_p2sh_addr, sidechain)
+        # TODO Stop skipping this test once signet is rebased on top of 0.17
+        if not self.options.parent_type == 'signet':
+            print("Test pegout P2SH")
+            parent_chain_addr = get_new_unconfidential_address(parent)
+            parent_pubkey = parent.validateaddress(parent_chain_addr)["pubkey"]
+            parent_chain_p2sh_addr = parent.createmultisig(1, [parent_pubkey])["address"]
+            self.test_pegout(parent_chain_p2sh_addr, sidechain)
 
         print("Test pegout Garbage")
         parent_chain_addr = "garbage"
@@ -290,7 +327,7 @@ def run_test(self):
         print ("Now test failure to validate peg-ins based on intermittant bitcoind rpc failure")
         stop_node(self.nodes[1], 1)
         txid = parent.sendtoaddress(addr, 1)
-        parent.generate(12)
+        self.parent_generate(parent, 12)
         proof = parent.gettxoutproof([txid])
         raw = parent.getrawtransaction(txid)
         stuck_peg = sidechain.claimpegin(raw, proof)

qa/rpc-tests/test_framework/util.py

@@ -341,7 +341,7 @@ def start_node(i, dirname, extra_args=None, rpchost=None, timewait=None, binary=
     if binary is None:
         binary = os.getenv("ELEMENTSD", "elementsd")
     args = [ binary, "-datadir="+datadir, "-server", "-keypool=1", "-discover=0", "-rest", "-mocktime="+str(get_mocktime()) ]
-    args.append('-regtest' if chain == 'regtest' else '-chain=' + chain)
+    args.append('-regtest' if chain == 'regtest' else '-signet' if chain == 'signet' else '-chain=' + chain)
     if extra_args is not None: args.extend(extra_args)
     bitcoind_processes[i] = subprocess.Popen(args)
     if os.getenv("PYTHON_DEBUG", ""):