init: Reap tested subdaemon processes to release OS resources

cdecker · rustyrussell · commit 36e060aa60b8 · 2019-01-08T00:16:50.000Z
The processes that were used to test the subdaemon versions were not
reaped correctly keeping some resources bound.

Signed-off-by: Christian Decker &lt;decker.christian@gmail.com&gt;
diff --git a/lightningd/lightningd.c b/lightningd/lightningd.c
@@ -293,6 +293,10 @@ void test_subdaemons(const struct lightningd *ld)
 		    || verstring[strlen(version())] != '\n')
 			errx(1, "%s: bad version '%s'",
 			     subdaemons[i], verstring);
+
+		/*~ finally reap the child process, freeing all OS
+		 *  resources that go with it */
+		waitpid(pid, NULL, 0);
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -293,6 +293,10 @@ void test_subdaemons(const struct lightningd *ld)`
`293`	`293`	`\|\| verstring[strlen(version())] != '\n')`
`294`	`294`	`errx(1, "%s: bad version '%s'",`
`295`	`295`	`subdaemons[i], verstring);`
	`296`	`+`
	`297`	`+ /*~ finally reap the child process, freeing all OS`
	`298`	`+ * resources that go with it */`
	`299`	`+ waitpid(pid, NULL, 0);`
`296`	`300`	`}`
`297`	`301`	`}`
`298`	`302`