Skip to content

Commit 647f591

Browse files
rustyrussellShahanaFarooqui
authored andcommitted
topology: fix overzealous deprecation check in listpeerchannels.
It's an output field (which we don't complain about), not an input field! Fixes: #7652 Changelog-Fixed: Logging: removed bogus "**BROKEN** plugin-topology: DEPRECATED API USED: listchannels.include_private" message. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
1 parent f816eef commit 647f591

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

plugins/topology.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,7 @@ static struct command_result *listpeerchannels_done(struct command *cmd,
394394
struct gossmap_localmods *mods;
395395

396396
/* In deprecated mode, re-add private channels */
397-
if (command_deprecated_in_ok(cmd, "include_private", "v24.02", "v24.08")) {
397+
if (command_deprecated_out_ok(cmd, "include_private", "v24.02", "v24.08")) {
398398
connected = local_connected(opts, buf, result);
399399
mods = gossmods_from_listpeerchannels(tmpctx, &local_id,
400400
buf, result, false,

tests/test_plugin.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4429,7 +4429,6 @@ def test_sql_crash(node_factory, bitcoind):
44294429
l1.rpc.sql(f"SELECT * FROM peerchannels;")
44304430

44314431

4432-
@pytest.mark.xfail(strict=True)
44334432
def test_listchannels_broken_message(node_factory):
44344433
"""This gave a bogus BROKEN message with deprecated-apis enabled"""
44354434
l1 = node_factory.get_node(options={'allow-deprecated-apis': True})

0 commit comments

Comments
 (0)