Skip to content

Commit 8f8202d

Browse files
committed
meta: Update release checklist
Add a version bump for clnrest and the main poetry.lock to the makefile and update the release checklist to include the new target. Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
1 parent cc2665d commit 8f8202d

File tree

3 files changed

+15
-3
lines changed

3 files changed

+15
-3
lines changed

Makefile

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -718,7 +718,9 @@ clean: obsclean
718718

719719

720720
PYLNS=client proto testing
721-
# See doc/MAKING-RELEASES.md
721+
# See doc/contribute-to-core-lightning/contributor-workflow.md
722+
update-py-versions: update-pyln-versions update-clnrest-version update-poetry-lock
723+
722724
update-pyln-versions: $(PYLNS:%=update-pyln-version-%)
723725

724726
update-pyln-version-%:
@@ -730,6 +732,13 @@ pyln-release: $(PYLNS:%=pyln-release-%)
730732
pyln-release-%:
731733
cd contrib/pyln-$* && $(MAKE) prod-release
732734

735+
update-clnrest-version:
736+
@if [ -z "$(NEW_VERSION)" ]; then echo "Set NEW_VERSION!" >&2; exit 1; fi
737+
cd plugins/clnrest && $(MAKE) upgrade-version
738+
739+
update-poetry-lock:
740+
poetry update clnrest pyln-client pyln-proto pyln-testing
741+
733742
update-mocks: $(ALL_TEST_PROGRAMS:%=update-mocks/%.c)
734743

735744
$(ALL_TEST_PROGRAMS:%=update-mocks/%.c): $(ALL_GEN_HEADERS) $(EXTERNAL_LIBS) libccan.a ccan/ccan/cdump/tools/cdump-enumstr config.vars

doc/contribute-to-core-lightning/contributor-workflow.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ Here's a checklist for the release process.
110110
2. Use `devtools/changelog.py` to collect the changelog entries from pull request commit messages and merge them into the manually maintained `CHANGELOG.md`. This does API queries to GitHub, which are severely
111111
ratelimited unless you use an API token: set the `GH_TOKEN` environment variable to a Personal Access Token from <https://github.com/settings/tokens>
112112
3. Create a new CHANGELOG.md heading to `v<VERSION>rc1`, and create a link at the bottom. Note that you should exactly copy the date and name format from a previous release, as the `build-release.sh` script relies on this.
113-
4. Update the contrib/pyln package versions: `make update-pyln-versions NEW_VERSION=<VERSION>`
113+
4. Update the contrib/pyln package versions: `make update-py-versions NEW_VERSION=<VERSION>`
114114
5. Create a PR with the above.
115115

116116
### Releasing -rc1
@@ -130,7 +130,7 @@ Here's a checklist for the release process.
130130
### Releasing -rc2, ..., -rcN
131131

132132
1. Change rc(N-1) to rcN in CHANGELOG.md.
133-
2. Update the contrib/pyln package versions: `make update-pyln-versions NEW_VERSION=<VERSION>`
133+
2. Update the contrib/pyln package versions: `make update-py-versions NEW_VERSION=<VERSION>`
134134
3. Add a PR with the rcN.
135135
4. Tag it `git pull && git tag -s v<VERSION>rcN && git push --tags`
136136
5. Announce tagged rc release on core-lightning's release-chat channel on Discord & [BuildOnL2](https://community.corelightning.org/c/general-questions/).

plugins/clnrest/Makefile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
upgrade-version:
2+
if [ -z "$(NEW_VERSION)" ]; then echo "Set NEW_VERSION!" >&2; exit 1; fi
3+
poetry version $(NEW_VERSION)

0 commit comments

Comments
 (0)