Skip to content

Commit d0e785a

Browse files
committed
pytest: don't run test_hook_in_use under VALGRIND on CI.
It's not reliable: ``` # We should have deferred hook update at least once! > l2.daemon.wait_for_log("UNUSUAL plugin-dep_b.py: Deferring registration of hook htlc_accepted until it's not in use.") tests/test_plugin.py:2646: ... if self.is_in_log(r): print("({} was previously in logs!)".format(r)) > raise TimeoutError('Unable to find "{}" in logs.'.format(exs)) E TimeoutError: Unable to find "[re.compile("UNUSUAL plugin-dep_b.py: Deferring registration of hook htlc_accepted until it's not in use.")]" in logs. ``` Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
1 parent fa42981 commit d0e785a

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

tests/test_plugin.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2614,6 +2614,7 @@ def test_htlc_accepted_hook_failonion(node_factory):
26142614
l1.rpc.pay(inv)
26152615

26162616

2617+
@pytest.mark.slow_test # VALGRIND running generally too slow to trigger race we need.
26172618
def test_hook_in_use(node_factory):
26182619
"""If a hook is in use when we add a plugin to it, we have to defer"""
26192620
dep_a = os.path.join(os.path.dirname(__file__), 'plugins/dep_a.py')

0 commit comments

Comments
 (0)