Refactor format_msat, fix formatting bug

Author: shesek

templates/completed.php

@@ -7,7 +7,7 @@
     Lightning rhash: <strong><?php echo $invoice->rhash ?></strong>
   </li>
   <li>
-    Invoice amount: <strong><?php echo rtrim(number_format($invoice->msatoshi/100000000, 8), "0.") ?> mBTC</strong>
+    Invoice amount: <strong><?php echo self::format_msat($invoice->msatoshi) ?></strong>
   </li>
   <li>
     Payment request: <strong><?php echo $invoice->payreq ?></strong>

templates/payment.php

@@ -7,7 +7,7 @@
   <h1>Pay with Lightning</h1>
   <h3>
     <?php if ($order->get_currency() !== 'BTC'): ?> <?php echo $order->get_total() ?> <?php echo $order->get_currency() ?> = <?php endif ?>
-    <?php echo rtrim(number_format($invoice->msatoshi/100000000, 8), "0.") ?> mBTC
+    <?php echo self::format_msat($invoice->msatoshi) ?>
   </h3>
   <img class="qr" src="<?php echo $qr_uri ?>">
   <code class="payreq"><?php echo $invoice->payreq ?></code>

woocommerce-gateway-lightning.php

@@ -246,6 +246,10 @@ protected static function make_desc($order) {
         if (count($products)) $desc = substr($desc, 0, -2) . ' and ' . count($products) . ' more items';
         return str_replace('"', '', $desc); // c-lightning's json parser doesn't like these, should eventually be fixed
       }
+
+      protected static function format_msat($msat) {
+        return rtrim(rtrim(number_format($msat/100000000, 8), '0'), '.') . ' mBTC';
+      }
     }
 
     new WC_Gateway_Lightning();