[Bug]: Lens of Disenchantment + Apotheosis Endersurge Gem = unbounded enchantment levels #1473
Description
General Info
- I am running a modpack (Craftoria 1.11.0)
- I can reproduce this issue consistently in single-player
- I can reproduce this issue consistently in multi-player
- I have searched for this issue previously and it was either (1) not previously reported, or (2) previously fixed and I am having the same problem.
- I am crashing and can provide my crash report(s)
- I am using the latest version of the mod
Forge/Neoforge version
Neoforge 21.1.90
Minecraft version
1.21.1
Mod version
1.3.12
Java version
21.0.2
Issue Description
When the Lens of Disenchantment disenchants an enchanted item with an Endersurge Gem from Apotheosis socketed inside, the Endersurge Gem's "+N levels to all existing enchantments" bonus is applied (along with all other enchantment level modifiers on the item) and the final level (not the old base level) becomes the new base level of the enchanted book and any leftover enchantments.
With the right setup, this can be repeated infinitely, leading to unbounded enchantment levels.
Please check if there's a function similar to Enchantment#getLevel which gets the enchantment's base level (instead of the level after modifiers) and if so, substitute a call to that function here:
Additional Information
Should be fixed by #1472.