Remove namespace "MPM" #1148
Open
Remove namespace "MPM" #1148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved all items under app/modules to respective conventional directories - Updated all references to phase out MPM namespace
…/remove-namespace-mpm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
closes: #1122
Moved files from app/module to conventional Laravel directories
Phased out the use of
namespace MPMand removedapp/moduledirectoryUpdated
DatabaseProxyService's create method to use firstOrCreateAre there any other side effects of this change that we should be aware of?
Any ongoing work on the backend will likely be affected by this change.
Describe how you tested your changes?
Reran migrations and seeders
No errors thrown
Tested various operations such as assigning a device to customer
Pull Request checklist
Please confirm you have completed any of the necessary steps below.