Create a NuGet package for the library

[andrasfuchs]

This library is great, could you create a NuGet package to make the installation/updating even easier?
It would also reach more people that way I think.

Here is a tutorial how to do that: https://softchris.github.io/pages/dotnet-nuget.html

[clintonrocksmith]

I would be happy to make this into a NuGet package and use Github Actions to do the publishing? It would be good if the NuGet account is owned by the EodHistoricalData company.

Putting the NuGet API keys etc into the secure settings in this Repository is also a good idea.
Maybe even for the APIToken to run the Unit Tests as well? So that it needs to pass the Unit Tests in order to distribute the NuGet package?

Thoughts?

[deios0]

I believe it's a perfect idea, or perhaps not to use NuGet at all, only JSON.NET library

[andrasfuchs]

I believe it's a perfect idea, or perhaps not to use NuGet at all, only JSON.NET library

I don't understand the connection between NuGet and JSON.NET, could you explain your idea here a little bit more?

[andrasfuchs]

@clintonrocksmith

I got the following reply from EODHistoricalData's customer service in July 2020 when I asked them about an issue in this repo:

Yes, we are the maintainer of .NET library, but we do not do the development as-is. Usually, our users contribute features and fixes and we accept it. I will ask the first contributor of this library for fixes you suggested, but, honestly, I’m not sure if he will fix it in any short period.

If you are .NET developer, you can use this library and contribute fixes you suggested, I guess it’s faster than build a new library or solution.

Things might have changed since then, but probably they are not willing to get involved with the NuGet package either.
So, I would say that it's worth a question, but otherwise feel free to make that package based on this repo under your name.

You will probably need extra rights to modify GitHub Actions though, and I'm not sure you can give you that.
@going-striker maybe?

[going-striker]

Hello everyone

First, thanks for the good words and the interest for this work I started.
I agree that having it in NuGet repository would be a nice improvement

Sadly I'm no more involved in the development of the project, working on other things on my side, although it can be interesting from me to touch a bit the whole NuGet thing on the "producer" side instead of just "customer" side

However, I don't think I will have time to do it anytime soon, and actually now, the ownership is to EODHistoricalData company, so I think the credentials to the account should be theirs

I think @clintonrocksmith is spot on about the approach to go with this, making important stuff available for contributors, while ownership still is with EODHistoricalData
Perhaps just confirm with them, and proceed with the method you suggested.
I'm pretty sure they will welcome a contribution that will increase visibility and user-friendliness.

Kind regards

[clintonrocksmith]

It gives users/consumers of the NuGet package confidence if it comes from the company who is providing the service.
As for Github actions, the whole process is just put into the repository under a folder structure called .github/workflows/

There a yaml file is created that does the build process etc. And then it pulls in the "secrets" which the maintainers/owners/authors can put into the github repository settings.

I think the effort to do the build process would take a weekend and it would be fun for me to do it. I can create it for my Nuget account to get the testing all done and then raise a PR with instructions on what is needed to complete it.

How does that sound?

[deios0]

We totally agree with it, of course, it will increase confidence. And we also provide 50% discounts for all our contributors, just let us know.