The library doesn't extend the hive size when applying transaction log entries

[msuhanov]

Hello.

The error message is:

The problem is here:

Registry/Registry/TransactionLog.cs

Line 211 in 2c8b9a4

Buffer.BlockCopy(dirtyPage.PageBytes, 0, hiveBytes, dirtyPage.Offset + baseOffset, dirtyPage.Size);

The problem is that the library doesn't support the extension of the hive file size, so an attempt to write beyond the current end of the hive file results in the exception shown above.

To resolve the issue, you need to read the "Hive bins data size" field of the log entry being applied and extend the hiveBytes length accordingly.

[EricZimmerman]

so if i am understanding this correctly, the dirty pages in the hive do not simply overwrite other pages in the main hive, but can EXPAND them?

so this becomes not a buffer copy per se, but potentially increasing the size of the data being written into the middle of the hive?

its not just a matter of adding extra data to the end of hiveBytes tho, as all the data would have to be moved when inserting the dirty page?

Its not clear if hiveBytes just needs made bigger and the pages still get overwritten as is. that is certainly a bit easier to do, but seems like other data has the possibility to be overwritten.

do you happen to have the GrownHive test file in your yarp repo? i didnt see it

[EricZimmerman]

To resolve the issue, you need to read the "Hive bins data size" field of the log entry being applied and extend the hiveBytes length accordingly.

do i literally just add that number of bytes to the size of the array/file @msuhanov ?

[EricZimmerman]

added this today. will track down test data to verify. if you have a test case that does this, please let me know

[EricZimmerman]

if you have a copy of Grownhive i can have @msuhanov, i would appreciate it. i have some examples from the wild that throw this error, but yarp and my code is still showing an error.

having a known good test case would be helpful