Version 1 shipping review #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix control launch
…to cleanup Merging
Gazebo control
* TF tree now connected, but robot falls over * robot doesn't fall down now, but sim is slow * use keti_gz_utils create instead * remove the 'heavy' link --------- Co-authored-by: brian <brian@erl-brian>
lkm1321
commented
Oct 30, 2024
Collaborator
Author
lkm1321
left a comment
lkm1321
left a comment
There was a problem hiding this comment.
@NikolaRaicevic2001 : some comments to address
| # 'ros.max_update_rate': 1.0, | ||
| # 'ros.filtered_cloud_topic': 'filtered_cloud', | ||
| # } | ||
| sensor_manager_parameters = { |
Collaborator
Author
There was a problem hiding this comment.
Can we read this from the yaml file instead?
Collaborator
There was a problem hiding this comment.
Yes, we should put it in yaml that is usually the convention
| # xacro_file=xacro_urdf_file, | ||
| # mappings=urdf_arguments | ||
| # ), | ||
| 'robot_description_semantic': get_xacro_command( |
Collaborator
Author
There was a problem hiding this comment.
TODO: move semantic to a description-type package, and publish to string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.