-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Add Remove button to Track distance > Map flow on web and mobile #80719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@Expensify/design do you guys think we even need the delete confirmation? I think I specifically named this button remove (instead of delete) because this feels way less "risky" than an actual delete action. Nothing's actually been created here, so you're not really deleting anything, you're just removing a potential waypoint. Not trying to get too semantic or anything over here 😂 just wondering if the extra confirmation is really necessary for such an easily reversible decision. |
|
Yeah I kinda agree that we don't need it for something that isn't destructive. Fine with removing it 👍 Curious if Shawn agrees |
|
Same, I can get down with that reasoning! |
|
Awesome - @mkzie2 can we make that change? We just want to remove the confirmation when clicking the remove button. It can just remove the waypoint and take them back to the main map screen 👍 |
This comment was marked as outdated.
This comment was marked as outdated.
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
@dannymcclain @bernhardoj I updated! |
|
We want the Remove button to behave the same way as the previous Delete waypoint, so it should only be shown when there are more than 2 waypoints. @dubielzyk-expensify agreed here |
@bernhardoj I think it should appear for all waypoints, as the mock data in the issue shows remove button on the Stop waypoint. |
|
@jamesdeanexpensify @Expensify/design can we have confirmation once more whether the Remove button should only show when there are more than 2 waypoints or not (just like the Delete waypoint that we are getting rid of) |
|
That makes sense to me, curious what the other designers think though. |
|
🤔 I feel like I would just expect to see that button all the time? Isn't all it is effectively doing is clearing the field and saving it empty? I don't feel super strongly, so if we want to proceed with how Delete currently works that fine, my 2 cents is that we might just be adding more logic than we need and it would be perfectly harmless to just show this all the time. CleanShot.2026-01-30.at.08.53.56.mp4 |
Fair point. I'm fine to have it show all the time. |
Explanation of Change
Fixed Issues
$ #80278
PROPOSAL: #80278 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-01-29.at.20.47.35.mov
Android: mWeb Chrome
Screen.Recording.2026-01-29.at.20.48.38.mov
iOS: Native
Screen.Recording.2026-01-29.at.20.49.18.mov
iOS: mWeb Safari
Screen.Recording.2026-01-29.at.20.50.15.mov
MacOS: Chrome / Safari
Screen.Recording.2026-01-29.at.20.51.08.mp4