Company Cards - Error is not shown when navigated to Company Cards page

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.11-17
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #80734
Email or phone of affected tester (no customers): applausetester+omqq1@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Web (Mac/Chrome)
App Component: Workspace Settings

Action Performed:

1. Open https://staging.new.expensify.com/
2. Navigate to Troubleshoot page
3. Enable "Simulate failing network requests"
4. Clear onyx data
5. Navigate to Workspaces tab
6. Create a workspace
7. Navigate to Company Cards

Expected Result:

The new error UI should be shown

Actual Result:

The standard landing page is shown instead of the error page.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @Ollyws

[melvin-bot]

Triggered auto assignment to @brianlee-expensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[MobileMage]

🚨 Edited by proposal-police: This proposal was edited at 2026-01-31 19:38:10 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

When navigating to the Company Cards page of a newly created workspace while "Simulate failing network requests" is enabled and Onyx data has been cleared, the expected error UI (introduced in PR #80734) does not appear. Instead, the standard landing/empty state page is shown, even though the backend request to load company card feeds has failed.

What is the root cause of that problem?

When a workspace is created optimistically with failing network requests, the policy object never receives a workspaceAccountID from the server because the CreateWorkspace API call fails. The optimistic policy data does not include workspaceAccountID, so it remains undefined.

App/src/libs/actions/Policy/Policy.ts

Lines 2247 to 2324 in 76a45ec

	value: {
	id: policyID,
	type: workspaceType,
	name: workspaceName,
	role: CONST.POLICY.ROLE.ADMIN,
	owner: currentUserEmailParam,
	ownerAccountID: currentUserAccountIDParam,
	isPolicyExpenseChatEnabled: true,
	outputCurrency,
	pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
	autoReporting: true,
	approver: currentUserEmailParam,
	autoReportingFrequency: shouldEnableWorkflowsByDefault ? CONST.POLICY.AUTO_REPORTING_FREQUENCIES.IMMEDIATE : CONST.POLICY.AUTO_REPORTING_FREQUENCIES.INSTANT,
	approvalMode:
	shouldEnableWorkflowsByDefault && engagementChoice !== CONST.ONBOARDING_CHOICES.TRACK_WORKSPACE ? CONST.POLICY.APPROVAL_MODE.BASIC : CONST.POLICY.APPROVAL_MODE.OPTIONAL,
	harvesting: {
	enabled: !shouldEnableWorkflowsByDefault,
	},
	created: DateUtils.getDBTime(),
	customUnits,
	areCategoriesEnabled: true,
	areCompanyCardsEnabled: true,
	areTagsEnabled: false,
	areDistanceRatesEnabled,
	areWorkflowsEnabled: shouldEnableWorkflowsByDefault,
	areReportFieldsEnabled: false,
	areConnectionsEnabled: false,
	areExpensifyCardsEnabled: false,
	employeeList: {
	[currentUserEmailParam]: {
	submitsTo: currentUserEmailParam,
	email: currentUserEmailParam,
	role: CONST.POLICY.ROLE.ADMIN,
	errors: {},
	},
	...(adminParticipant?.login
	? {
	[adminParticipant.login]: {
	submitsTo: currentUserEmailParam,
	email: adminParticipant.login,
	role: CONST.POLICY.ROLE.ADMIN,
	errors: {},
	},
	}
	: {}),
	},
	chatReportIDAdmins: makeMeAdmin ? adminsChatReportID.toString() : undefined,
	pendingFields: {
	autoReporting: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
	approvalMode: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
	reimbursementChoice: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
	name: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
	outputCurrency: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
	address: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
	description: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
	type: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
	areReportFieldsEnabled: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
	customRules: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
	},
	defaultBillable: false,
	defaultReimbursable: true,
	disabledFields: {defaultBillable: true, reimbursable: false},
	avatarURL: file?.uri,
	originalFileName: file?.name,
	...optimisticMccGroupData.optimisticData,
	requiresCategory: true,
	fieldList: {
	[CONST.POLICY.FIELDS.FIELD_LIST_TITLE]: {
	defaultValue: CONST.POLICY.DEFAULT_REPORT_NAME_PATTERN,
	pendingFields: {defaultValue: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD, deletable: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD},
	type: CONST.POLICY.DEFAULT_FIELD_LIST_TYPE,
	target: CONST.POLICY.DEFAULT_FIELD_LIST_TARGET,
	name: CONST.POLICY.DEFAULT_FIELD_LIST_NAME,
	fieldID: CONST.POLICY.FIELDS.FIELD_LIST_TITLE,
	deletable: true,
	},
	},
	},

As a result, on the Company Cards page, workspaceAccountID falls back to CONST.DEFAULT_NUMBER_ID (which is 0), and domainOrWorkspaceAccountID also resolves to 0.

App/src/pages/workspace/companyCards/WorkspaceCompanyCardsPage.tsx

Lines 32 to 45 in 76a45ec

	const workspaceAccountID = policy?.workspaceAccountID ?? CONST.DEFAULT_NUMBER_ID;
	const companyCards = useCompanyCards({policyID});
	const {
	allCardFeeds,
	feedName,
	selectedFeed,
	bankName,
	isFeedPending,
	isFeedAdded,
	onyxMetadata: {cardListMetadata},
	} = companyCards;
	const domainOrWorkspaceAccountID = getDomainOrWorkspaceAccountID(workspaceAccountID, selectedFeed);

The openPolicyCompanyCardsPage function is then called with domainOrWorkspaceAccountID = 0, and both its optimistic and failure data are written to the Onyx collection key sharedNVP_private_domain_member_0.

App/src/libs/actions/CompanyCards.ts

Lines 842 to 881 in 76a45ec

	function openPolicyCompanyCardsPage(policyID: string, domainOrWorkspaceAccountID: number, translate: LocaleContextProps['translate']) {
	const optimisticData: Array<OnyxUpdate<typeof ONYXKEYS.COLLECTION.SHARED_NVP_PRIVATE_DOMAIN_MEMBER>> = [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.SHARED_NVP_PRIVATE_DOMAIN_MEMBER}${domainOrWorkspaceAccountID}`,
	value: {
	isLoading: true,
	errors: null,
	},
	},
	];
	const successData: Array<OnyxUpdate<typeof ONYXKEYS.COLLECTION.SHARED_NVP_PRIVATE_DOMAIN_MEMBER>> = [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.SHARED_NVP_PRIVATE_DOMAIN_MEMBER}${domainOrWorkspaceAccountID}`,
	value: {
	isLoading: false,
	},
	},
	];
	const failureData: Array<OnyxUpdate<typeof ONYXKEYS.COLLECTION.SHARED_NVP_PRIVATE_DOMAIN_MEMBER>> = [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.SHARED_NVP_PRIVATE_DOMAIN_MEMBER}${domainOrWorkspaceAccountID}`,
	value: {
	isLoading: false,
	errors: {
	[CONST.COMPANY_CARDS.WORKSPACE_FEEDS_LOAD_ERROR]: translate('workspace.companyCards.error.workspaceFeedsCouldNotBeLoadedMessage'),
	},
	},
	},
	];
	const params: OpenPolicyExpensifyCardsPageParams = {
	policyID,
	};
	API.read(READ_COMMANDS.OPEN_POLICY_COMPANY_CARDS_PAGE, params, {optimisticData, successData, failureData});

However, Onyx is configured with skippableCollectionMemberIDs that includes the string '0' (derived from DEFAULT_NUMBER_ID). This causes Onyx to silently discard any writes to collection keys whose member ID suffix is '0'.

App/src/CONST/index.ts

Line 7944 in 76a45ec

SKIPPABLE_COLLECTION_MEMBER_IDS: [String(DEFAULT_NUMBER_ID), '-1', 'undefined', 'null', 'NaN'] as string[],

App/src/setup/index.ts

Line 61 in 76a45ec

skippableCollectionMemberIDs: CONST.SKIPPABLE_COLLECTION_MEMBER_IDS,

Because the failure data (containing the error) is silently dropped by Onyx, the workspaceCardFeedsErrors in the Table component remains undefined, feedErrorKey is never set, and the error UI at line 377 never renders. Instead, the isNoFeed condition at line 356 is true (since no feed data was loaded) and the empty state is shown.

App/src/pages/workspace/companyCards/WorkspaceCompanyCardsTable/index.tsx

Lines 97 to 104 in 76a45ec

	const areWorkspaceCardFeedsLoading = !!workspaceCardFeedsStatus?.[domainOrWorkspaceAccountID]?.isLoading;
	const workspaceCardFeedsErrors = workspaceCardFeedsStatus?.[domainOrWorkspaceAccountID]?.errors;
	const selectedFeedStatus = selectedFeed?.status;
	const selectedFeedErrors = selectedFeedStatus?.errors;
	const [feedErrorKey, feedErrorMessage] = Object.entries(workspaceCardFeedsErrors ?? selectedFeedErrors ?? {}).at(0) ?? [];
	const hasFeedErrors = !!feedErrorKey;

App/src/pages/workspace/companyCards/WorkspaceCompanyCardsTable/index.tsx

Lines 356 to 377 in 76a45ec

	{(isLoading || isFeedPending || isNoFeed) && !feedErrorKey && (
	<ScrollView>
	{isLoading && <TableRowSkeleton fixedNumItems={5} />}
	{!isLoading && isFeedPending && (
	<View style={styles.flex1}>
	<WorkspaceCompanyCardsFeedPendingPage />
	</View>
	)}
	{!isLoading && isNoFeed && (
	<View style={styles.flex1}>
	<WorkspaceCompanyCardPageEmptyState
	policyID={policyID}
	shouldShowGBDisclaimer={shouldShowGBDisclaimer}
	/>
	</View>
	)}
	</ScrollView>
	)}
	{!!feedErrorKey && !isLoading && (

What changes do you think we should make in order to solve the problem?

The fix requires two small changes, both focused on handling the case where domainOrWorkspaceAccountID equals CONST.DEFAULT_NUMBER_ID.

In src/pages/workspace/companyCards/WorkspaceCompanyCardsTable/index.tsx, the workspaceCardFeedsErrors computation (around line 98) should detect when domainOrWorkspaceAccountID === CONST.DEFAULT_NUMBER_ID and the user is not offline, and treat this as a workspace feeds load error directly rather than relying on Onyx-stored error data. The logic would check domainOrWorkspaceAccountID === CONST.DEFAULT_NUMBER_ID && !isOffline and, when true, synthesize the same error object that the openPolicyCompanyCardsPage failure handler would have written: { [CONST.COMPANY_CARDS.WORKSPACE_FEEDS_LOAD_ERROR]: translate('workspace.companyCards.error.workspaceFeedsCouldNotBeLoadedMessage') }. This feeds into the existing feedErrorKey / feedErrorMessage / feedErrorTitle logic and the error BlockingView at line 377 renders correctly, reusing all the existing error UI code without any new components or props.

App/src/pages/workspace/companyCards/WorkspaceCompanyCardsTable/index.tsx

Lines 97 to 114 in 76a45ec

	const areWorkspaceCardFeedsLoading = !!workspaceCardFeedsStatus?.[domainOrWorkspaceAccountID]?.isLoading;
	const workspaceCardFeedsErrors = workspaceCardFeedsStatus?.[domainOrWorkspaceAccountID]?.errors;
	const selectedFeedStatus = selectedFeed?.status;
	const selectedFeedErrors = selectedFeedStatus?.errors;
	const [feedErrorKey, feedErrorMessage] = Object.entries(workspaceCardFeedsErrors ?? selectedFeedErrors ?? {}).at(0) ?? [];
	const hasFeedErrors = !!feedErrorKey;
	let feedErrorTitle: string | undefined;
	let feedErrorReloadAction: (() => void) | undefined;
	if (feedErrorKey === CONST.COMPANY_CARDS.WORKSPACE_FEEDS_LOAD_ERROR) {
	feedErrorTitle = translate('workspace.companyCards.error.workspaceFeedsCouldNotBeLoadedTitle');
	feedErrorReloadAction = onReloadPage;
	} else if (feedErrorKey === CONST.COMPANY_CARDS.FEED_LOAD_ERROR) {
	feedErrorTitle = translate('workspace.companyCards.error.feedCouldNotBeLoadedTitle');
	feedErrorReloadAction = onReloadFeed;
	}

In src/pages/workspace/companyCards/WorkspaceCompanyCardsPage.tsx, the loadPolicyCompanyCardsPage callback (line 47) should include an early return when domainOrWorkspaceAccountID === CONST.DEFAULT_NUMBER_ID to avoid making a useless API call whose result would be silently discarded by Onyx anyway. This also ensures that when the user taps "Try Again" on the error UI, the retry only fires once the workspace has been properly created and has a valid workspaceAccountID. When the network recovers and the workspace creation succeeds, workspaceAccountID becomes a valid non-zero number, the domainOrWorkspaceAccountID value changes, the useEffect dependency triggers a re-run, and the openPolicyCompanyCardsPage call proceeds with a valid key.

App/src/pages/workspace/companyCards/WorkspaceCompanyCardsPage.tsx

Lines 47 to 63 in 76a45ec

	const loadPolicyCompanyCardsPage = useCallback(() => {
	openPolicyCompanyCardsPage(policyID, domainOrWorkspaceAccountID, translate);
	}, [domainOrWorkspaceAccountID, policyID, translate]);
	const {isOffline} = useNetwork({
	onReconnect: loadPolicyCompanyCardsPage,
	});
	const isLoading = !isOffline && (!allCardFeeds || (isFeedAdded && isLoadingOnyxValue(cardListMetadata)));
	useEffect(() => {
	if (isOffline) {
	return;
	}
	loadPolicyCompanyCardsPage();
	}, [policyID, domainOrWorkspaceAccountID, loadPolicyCompanyCardsPage, isOffline]);

What alternative solutions did you explore? (Optional)

N/A

[annaweber830]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When Company Cards is opened for a newly created workspace while failing network requests are simulated, the workspace feeds request fails but the page still shows the standard empty state instead of the new error UI. The error state never surfaces to the table, so the blocking error view never renders.

What is the root cause of that problem?

openPolicyCompanyCardsPage writes the workspace-feeds error into the shared NVP collection key using the provided domainOrWorkspaceAccountID. When the workspace was created optimistically during failing network requests, workspaceAccountID is still missing and WorkspaceCompanyCardsPage falls back to CONST.DEFAULT_NUMBER_ID (0), so the failure write targets sharedNVP_private_domain_member_0.

App/src/libs/actions/CompanyCards.ts

Lines 842 to 875 in 7697759

	function openPolicyCompanyCardsPage(policyID: string, domainOrWorkspaceAccountID: number, translate: LocaleContextProps['translate']) {
	const optimisticData: Array<OnyxUpdate<typeof ONYXKEYS.COLLECTION.SHARED_NVP_PRIVATE_DOMAIN_MEMBER>> = [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.SHARED_NVP_PRIVATE_DOMAIN_MEMBER}${domainOrWorkspaceAccountID}`,
	value: {
	isLoading: true,
	errors: null,
	},
	},
	];
	const successData: Array<OnyxUpdate<typeof ONYXKEYS.COLLECTION.SHARED_NVP_PRIVATE_DOMAIN_MEMBER>> = [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.SHARED_NVP_PRIVATE_DOMAIN_MEMBER}${domainOrWorkspaceAccountID}`,
	value: {
	isLoading: false,
	},
	},
	];
	const failureData: Array<OnyxUpdate<typeof ONYXKEYS.COLLECTION.SHARED_NVP_PRIVATE_DOMAIN_MEMBER>> = [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.SHARED_NVP_PRIVATE_DOMAIN_MEMBER}${domainOrWorkspaceAccountID}`,
	value: {
	isLoading: false,
	errors: {
	[CONST.COMPANY_CARDS.WORKSPACE_FEEDS_LOAD_ERROR]: translate('workspace.companyCards.error.workspaceFeedsCouldNotBeLoadedMessage'),
	},
	},
	},
	];

Because Onyx is configured to skip collection member IDs that match String(DEFAULT_NUMBER_ID) (i.e., '0'), writes to sharedNVP_private_domain_member_0 are discarded and the error never reaches workspaceCardFeedsStatus, so the table falls back to the no-feed empty state instead of the error UI.

App/src/pages/workspace/companyCards/WorkspaceCompanyCardsPage.tsx

Lines 31 to 63 in 7697759

	const policy = usePolicy(policyID);
	const workspaceAccountID = policy?.workspaceAccountID ?? CONST.DEFAULT_NUMBER_ID;
	const companyCards = useCompanyCards({policyID});
	const {
	allCardFeeds,
	feedName,
	selectedFeed,
	bankName,
	isFeedPending,
	isFeedAdded,
	onyxMetadata: {cardListMetadata},
	} = companyCards;
	const domainOrWorkspaceAccountID = getDomainOrWorkspaceAccountID(workspaceAccountID, selectedFeed);
	const loadPolicyCompanyCardsPage = useCallback(() => {
	openPolicyCompanyCardsPage(policyID, domainOrWorkspaceAccountID, translate);
	}, [domainOrWorkspaceAccountID, policyID, translate]);
	const {isOffline} = useNetwork({
	onReconnect: loadPolicyCompanyCardsPage,
	});
	const isLoading = !isOffline && (!allCardFeeds || (isFeedAdded && isLoadingOnyxValue(cardListMetadata)));
	useEffect(() => {
	if (isOffline) {
	return;
	}
	loadPolicyCompanyCardsPage();
	}, [policyID, domainOrWorkspaceAccountID, loadPolicyCompanyCardsPage, isOffline]);

App/src/setup/index.ts

Lines 46 to 62 in 7697759

	initialKeyStates: {
	// Clear any loading and error messages so they do not appear on app startup
	[ONYXKEYS.SESSION]: {loading: false},
	[ONYXKEYS.ACCOUNT]: CONST.DEFAULT_ACCOUNT_DATA,
	[ONYXKEYS.NETWORK]: CONST.DEFAULT_NETWORK_DATA,
	[ONYXKEYS.IS_SIDEBAR_LOADED]: false,
	[ONYXKEYS.SHOULD_SHOW_COMPOSE_INPUT]: true,
	[ONYXKEYS.MODAL]: {
	isVisible: false,
	willAlertModalBecomeVisible: false,
	},
	// Ensure the Supportal permission modal doesn't persist across reloads
	[ONYXKEYS.SUPPORTAL_PERMISSION_DENIED]: null,
	[ONYXKEYS.IS_OPEN_APP_FAILURE_MODAL_OPEN]: false,
	},
	skippableCollectionMemberIDs: CONST.SKIPPABLE_COLLECTION_MEMBER_IDS,
	});

App/src/CONST/index.ts

Lines 7940 to 7947 in 7697759

	LAST_PAYMENT_METHOD: {
	LAST_USED: 'lastUsed',
	IOU: 'iou',
	EXPENSE: 'expense',
	INVOICE: 'invoice',
	},
	SKIPPABLE_COLLECTION_MEMBER_IDS: [String(DEFAULT_NUMBER_ID), '-1', 'undefined', 'null', 'NaN'] as string[],
	SETUP_SPECIALIST_LOGIN: 'Setup Specialist',

What changes do you think we should make in order to solve the problem?

First, treat a missing workspace account ID as a workspace-feeds load error in WorkspaceCompanyCardsTable when we are online. This preserves the existing error UI and ensures the error view renders even if the Onyx write was skipped. This should only kick in after the policy is loaded to avoid flashing errors during initial load.

App/src/pages/workspace/companyCards/WorkspaceCompanyCardsTable/index.tsx

Lines 97 to 103 in 7697759

	const areWorkspaceCardFeedsLoading = !!workspaceCardFeedsStatus?.[domainOrWorkspaceAccountID]?.isLoading;
	const workspaceCardFeedsErrors = workspaceCardFeedsStatus?.[domainOrWorkspaceAccountID]?.errors;
	const selectedFeedStatus = selectedFeed?.status;
	const selectedFeedErrors = selectedFeedStatus?.errors;
	const [feedErrorKey, feedErrorMessage] = Object.entries(workspaceCardFeedsErrors ?? selectedFeedErrors ?? {}).at(0) ?? [];

const areWorkspaceCardFeedsLoading = !!workspaceCardFeedsStatus?.[domainOrWorkspaceAccountID]?.isLoading;
const shouldShowWorkspaceFeedsLoadError = domainOrWorkspaceAccountID === CONST.DEFAULT_NUMBER_ID && isPolicyLoaded && !isOffline;
const workspaceCardFeedsErrors = shouldShowWorkspaceFeedsLoadError
    ? {[CONST.COMPANY_CARDS.WORKSPACE_FEEDS_LOAD_ERROR]: translate('workspace.companyCards.error.workspaceFeedsCouldNotBeLoadedMessage')}
    : workspaceCardFeedsStatus?.[domainOrWorkspaceAccountID]?.errors;

const selectedFeedStatus = selectedFeed?.status;
const selectedFeedErrors = selectedFeedStatus?.errors;

const [feedErrorKey, feedErrorMessage] = Object.entries(workspaceCardFeedsErrors ?? selectedFeedErrors ?? {}).at(0) ?? [];

Second, avoid making the openPolicyCompanyCardsPage read when the workspace account ID is still missing. This keeps us from issuing a call that can only write to a skippable key, and makes the “Try again” button naturally wait until the workspace account ID is available.

App/src/pages/workspace/companyCards/WorkspaceCompanyCardsPage.tsx

Lines 47 to 49 in 7697759

	const loadPolicyCompanyCardsPage = useCallback(() => {
	openPolicyCompanyCardsPage(policyID, domainOrWorkspaceAccountID, translate);
	}, [domainOrWorkspaceAccountID, policyID, translate]);

const loadPolicyCompanyCardsPage = useCallback(() => {
    if (domainOrWorkspaceAccountID === CONST.DEFAULT_NUMBER_ID) {
        return;
    }

    openPolicyCompanyCardsPage(policyID, domainOrWorkspaceAccountID, translate);
}, [domainOrWorkspaceAccountID, policyID, translate]);

What alternative solutions did you explore? (Optional)

Considered removing DEFAULT_NUMBER_ID from SKIPPABLE_COLLECTION_MEMBER_IDS, but that would affect all collection writes across the app and could reintroduce noisy Onyx keys for other features. The targeted UI fallback plus guard keeps the fix localized to Company Cards.

[khaoticvs]

One thing to double-check: when the workspace is created optimistically and the network is failing, workspaceAccountID can be undefined and fall back to DEFAULT_NUMBER_ID (0). Since Onyx skips collection member ID "0", any failure data written there will be dropped silently.

Two possible mitigations to consider:

1. Guard the read: early-return from openPolicyCompanyCardsPage when domainOrWorkspaceAccountID === DEFAULT_NUMBER_ID, so we don’t issue a no-op request.
2. UI fallback: when online and domainOrWorkspaceAccountID === DEFAULT_NUMBER_ID after policy load, synthesize a WORKSPACE_FEEDS_LOAD_ERROR locally so the existing error UI can render.

Both approaches keep the fix localized without changing global Onyx behavior.

[melvin-bot]

📣 @khaoticvs! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>