Android - Report - App freezes after splitting an expense and selecting one of the splits.

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.53.0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-16382/folder/13176791/41237172/1309879966
Email or phone of affected tester (no customers): ibellicotest+2250@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Critical User Impact
Device used: Motorola MotoG60 / Android 12 (Hybrid app)
App Component: Money Requests

Action Performed:

Prerequisite: Account has at least one workspace.

1. Open the Expensify app.
2. Open any workspace chat.
3. Create a manual expense.
4. Open the just created expense.
5. Tap on "More" > "Split" > "Save"
6. Once redirected to report again, select one of the splits.
7. Note that app becomes unresponsive after the last action.

Expected Result:

User should be able to continue using the app without any issue after splitting an expense and selecting one of the splits.

Actual Result:

App becomes unresponsive after splitting an expense and selecting one of the splits.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7123324_1775534924520!log.txt

Bug7123324_1775534924523.Freeze.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

Investigation Summary

Classification: Frontend bug
Causing PR: #86931 - "fix: Extra hold expense comment appears after splitting held expense [#86798]" by @dmkt9 (Medium confidence)
Related Issues: #86798

Recommendation: REVERT

PR #86931 is the most likely cause. It modifies src/libs/actions/IOU/Split.ts directly, touching the core updateSplitTransactions function that runs when a user saves a split. The QA steps in that PR closely match the bug reproduction steps (workspace chat, create manual expense, More > Split > Save, then tap a split). Additionally, when this PR was deployed to staging at version 9.3.53-0, the Android and iOS builds explicitly showed failure status in the bot comment - consistent with this being an Android HybridApp issue only.

The PR introduced a complex loop with a multi-condition check to identify the hold comment report action. If this produces incorrect or unexpected optimistic Onyx data for the transaction thread, the withReportAndReportActionOrNotFound HOC (used by SplitBillDetailsPage) may get stuck in a permanent loading state when the user taps on a split, making the app appear unresponsive.

Evidence:

• PR fix: Extra hold expense comment appears after splitting held expense [#86798] #86931 is the only staging PR that directly modifies src/libs/actions/IOU/Split.ts
• Reproduction steps match the QA steps in PR fix: Extra hold expense comment appears after splitting held expense [#86798] #86931 very closely
• Staging deploy at 9.3.53-0 showed Android failure and iOS failure
• Bug is staging-only (not production), confirming it was introduced by a recent staging PR

Verification:

• Affected code path: src/libs/actions/IOU/Split.ts (updateSplitTransactions function)
• PR fix: Extra hold expense comment appears after splitting held expense [#86798] #86931 confirmed to modify this file
• SplitBillDetailsPage.tsx uses withReportAndReportActionOrNotFound HOC, which shows infinite loading if report action data is malformed

Root Cause:
PR #86931 refactored how the hold comment is identified during updateSplitTransactions. The new loop at around line 1204 in Split.ts identifies the hold comment report action and stores it in holdCommentReportAction. If this logic produces incorrect optimistic Onyx data, the withReportAndReportActionOrNotFound HOC may enter an infinite loading state when isLoadingReportAction never resolves - making the app appear unresponsive on Android HybridApp.

Labels: DeployBlocker removed (this is a frontend bug requiring a fix in Expensify/App, not the backend). DeployBlockerCash retained.