audit: constant backed slug literal in data-machine (25)

[homeboy-ci]

Audit: constant backed slug literal

Component: data-machine
Count: 28 findings
Last run: https://github.com/Extra-Chill/data-machine/actions/runs/25473779213
Updated: 2026-05-07T03:09:07Z
Homeboy: homeboy 0.158.0+d6fcc445 | Action: Extra-Chill/homeboy-action@v2

Findings

File	Description	Suggestion
inc/Engine/Bundle/AgentBundleFlowFile.php	Raw slug literal prompt_queue at line 128 duplicates constant DM_System_Task_Config_Passthrough_QueueAbility_Stub::SLOT_PROMPT_QUEUE	Use DM_System_Task_Config_Passthrough_QueueAbility_Stub::SLOT_PROMPT_QUEUE instead of repeating the literal slug so the constant remains the source of truth.
inc/Engine/Bundle/AgentBundleFlowFile.php	Raw slug literal prompt_queue at line 128 duplicates constant QueueAbility::SLOT_PROMPT_QUEUE	Use QueueAbility::SLOT_PROMPT_QUEUE instead of repeating the literal slug so the constant remains the source of truth.
inc/Engine/Bundle/AgentBundleFlowFile.php	Raw slug literal prompt_queue at line 128 duplicates constant QueueAbility::SLOT_PROMPT_QUEUE	Use QueueAbility::SLOT_PROMPT_QUEUE instead of repeating the literal slug so the constant remains the source of truth.
inc/Engine/Bundle/AgentBundleFlowFile.php	Raw slug literal prompt_queue at line 128 duplicates constant QueueAbility::SLOT_PROMPT_QUEUE	Use QueueAbility::SLOT_PROMPT_QUEUE instead of repeating the literal slug so the constant remains the source of truth.
inc/Engine/Bundle/AgentBundleFlowFile.php	Raw slug literal prompt_queue at line 128 duplicates constant QueueAbility::SLOT_PROMPT_QUEUE	Use QueueAbility::SLOT_PROMPT_QUEUE instead of repeating the literal slug so the constant remains the source of truth.
inc/Engine/Bundle/AgentBundleFlowFile.php	Raw slug literal prompt_queue at line 128 duplicates constant QueueAbility::SLOT_PROMPT_QUEUE	Use QueueAbility::SLOT_PROMPT_QUEUE instead of repeating the literal slug so the constant remains the source of truth.
inc/Engine/Bundle/AgentBundleFlowFile.php	Raw slug literal prompt_queue at line 128 duplicates constant QueueAbility::SLOT_PROMPT_QUEUE	Use QueueAbility::SLOT_PROMPT_QUEUE instead of repeating the literal slug so the constant remains the source of truth.
inc/Engine/Bundle/AgentBundleFlowFile.php	Raw slug literal prompt_queue at line 128 duplicates constant QueueAbility::SLOT_PROMPT_QUEUE	Use QueueAbility::SLOT_PROMPT_QUEUE instead of repeating the literal slug so the constant remains the source of truth.
inc/Engine/Bundle/AgentBundleFlowFile.php	Raw slug literal prompt_queue at line 128 duplicates constant QueueAbility::SLOT_PROMPT_QUEUE	Use QueueAbility::SLOT_PROMPT_QUEUE instead of repeating the literal slug so the constant remains the source of truth.
inc/migrations/site-md.php	Raw slug literal data-machine at line 369 duplicates constant DrainCommand::GROUP	Use DrainCommand::GROUP instead of repeating the literal slug so the constant remains the source of truth.
inc/migrations/site-md.php	Raw slug literal data-machine at line 369 duplicates constant DrainJobAbility::GROUP	Use DrainJobAbility::GROUP instead of repeating the literal slug so the constant remains the source of truth.
inc/migrations/site-md.php	Raw slug literal data-machine at line 369 duplicates constant RecurringScheduler::GROUP	Use RecurringScheduler::GROUP instead of repeating the literal slug so the constant remains the source of truth.
inc/migrations/site-md.php	Raw slug literal data-machine at line 425 duplicates constant DrainCommand::GROUP	Use DrainCommand::GROUP instead of repeating the literal slug so the constant remains the source of truth.
inc/migrations/site-md.php	Raw slug literal data-machine at line 425 duplicates constant DrainJobAbility::GROUP	Use DrainJobAbility::GROUP instead of repeating the literal slug so the constant remains the source of truth.
inc/migrations/site-md.php	Raw slug literal data-machine at line 425 duplicates constant RecurringScheduler::GROUP	Use RecurringScheduler::GROUP instead of repeating the literal slug so the constant remains the source of truth.
tests/pending-action-helper-approval-envelope-smoke.php	Raw slug literal data-machine at line 122 duplicates constant DrainCommand::GROUP	Use DrainCommand::GROUP instead of repeating the literal slug so the constant remains the source of truth.
tests/pending-action-helper-approval-envelope-smoke.php	Raw slug literal data-machine at line 122 duplicates constant DrainJobAbility::GROUP	Use DrainJobAbility::GROUP instead of repeating the literal slug so the constant remains the source of truth.
tests/pending-action-helper-approval-envelope-smoke.php	Raw slug literal data-machine at line 122 duplicates constant RecurringScheduler::GROUP	Use RecurringScheduler::GROUP instead of repeating the literal slug so the constant remains the source of truth.
tests/queue-payload-split-smoke.php	Raw slug literal prompt_queue at line 514 duplicates constant DM_System_Task_Config_Passthrough_QueueAbility_Stub::SLOT_PROMPT_QUEUE	Use DM_System_Task_Config_Passthrough_QueueAbility_Stub::SLOT_PROMPT_QUEUE instead of repeating the literal slug so the constant remains the source of truth.
tests/queue-payload-split-smoke.php	Raw slug literal prompt_queue at line 514 duplicates constant QueueAbility::SLOT_PROMPT_QUEUE	Use QueueAbility::SLOT_PROMPT_QUEUE instead of repeating the literal slug so the constant remains the source of truth.
tests/queue-payload-split-smoke.php	Raw slug literal prompt_queue at line 514 duplicates constant QueueAbility::SLOT_PROMPT_QUEUE	Use QueueAbility::SLOT_PROMPT_QUEUE instead of repeating the literal slug so the constant remains the source of truth.
tests/queue-payload-split-smoke.php	Raw slug literal prompt_queue at line 514 duplicates constant QueueAbility::SLOT_PROMPT_QUEUE	Use QueueAbility::SLOT_PROMPT_QUEUE instead of repeating the literal slug so the constant remains the source of truth.
tests/queue-payload-split-smoke.php	Raw slug literal prompt_queue at line 514 duplicates constant QueueAbility::SLOT_PROMPT_QUEUE	Use QueueAbility::SLOT_PROMPT_QUEUE instead of repeating the literal slug so the constant remains the source of truth.
tests/queue-payload-split-smoke.php	Raw slug literal prompt_queue at line 514 duplicates constant QueueAbility::SLOT_PROMPT_QUEUE	Use QueueAbility::SLOT_PROMPT_QUEUE instead of repeating the literal slug so the constant remains the source of truth.
tests/queue-payload-split-smoke.php	Raw slug literal prompt_queue at line 514 duplicates constant QueueAbility::SLOT_PROMPT_QUEUE	Use QueueAbility::SLOT_PROMPT_QUEUE instead of repeating the literal slug so the constant remains the source of truth.
tests/queue-payload-split-smoke.php	Raw slug literal prompt_queue at line 514 duplicates constant QueueAbility::SLOT_PROMPT_QUEUE	Use QueueAbility::SLOT_PROMPT_QUEUE instead of repeating the literal slug so the constant remains the source of truth.
tests/queue-payload-split-smoke.php	Raw slug literal prompt_queue at line 514 duplicates constant QueueAbility::SLOT_PROMPT_QUEUE	Use QueueAbility::SLOT_PROMPT_QUEUE instead of repeating the literal slug so the constant remains the source of truth.
tests/transcript-policy-smoke.php	Raw slug literal datamachine_persist_pipeline_transcripts at line 50 duplicates constant PipelineTranscriptPolicy::OPTION_NAME	Use PipelineTranscriptPolicy::OPTION_NAME instead of repeating the literal slug so the constant remains the source of truth.

Autofix status

❌ No fixer available for constant_backed_slug_literal

---

Maintained automatically by Homeboy Action on each CI run until resolved.

[chubes4]

Closing — all 25 findings are upstream detector noise.

Parser glitch (12 findings): has::GROUP is the word "has" in the docblock prose "This class has no knowledge of flows..." of RecurringScheduler.php being matched as a class name. Filed: Extra-Chill/homeboy-extensions#425.

Semantic conflations (the rest):

• 'data-machine' literals in site-md.php and pending-action-helper-approval-envelope-smoke.php are the plugin slug / adapter identifier, not Action Scheduler's DrainCommand::GROUP. They share a value but mean different things; substituting the constant would couple plugin-slug detection to AS group naming.
• 'prompt_queue' in AgentBundleFlowFile.php:128 is a JSON field name in the portable bundle file format, not the runtime QueueAbility::SLOT_PROMPT_QUEUE constant. Bundles are versioned external data; coupling bundle JSON keys to internal class constants is the wrong abstraction.
• 'datamachine_persist_pipeline_transcripts' in transcript-policy-smoke.php:50 is inside a get_option() stub that deliberately inlines the option key to verify production code uses that exact name. Replacing with PipelineTranscriptPolicy::OPTION_NAME would defeat the test (it would just verify the constant equals itself).
• 'prompt_queue' in queue-payload-split-smoke.php:514 is the same pattern: testing that CLI routing emits the expected slot name string.

Repeat noise: Same finding emitted 9× per literal because multiple SLOT_PROMPT_QUEUE constants exist (real + test stub). Also covered in homeboy-extensions#425 ("deduplicate findings per file/line/value").

The legitimate fix from this audit batch (Jobs facade passthrough, #1787) shipped in #1804.