Use string for faction in game launch message

[Sheikah45]

It would be nice to consistently use the string version of faction in all the messages from the server. All clients going back to 1.4.6 are able to handle the faction as a string.

1.4.6 is the current minimum version of the client

[Sheikah45]

I don't know if this needs to wait until v2.0 since all clients are designed to be able to use a string or an int as the faction serialization. So it is not a breaking change.

[Askaholic]

It’s still a breaking API change. I’ve written a bit about this topic here: https://github.com/FAForever/server/blob/develop/CONTRIBUTING.md#version-numbers

[BlackYps]

Does that mean that client version 1.6 has to wait for server v2.0?

[Askaholic]

No? The client should not depend on a breaking change existing, especially when that change isn’t merged.

[BlackYps]

Seems like Sheikah has some work to do to fix the release candidate then xD

[Sheikah45]

I actually already have a pr that fixes it. Just requested this on principle XP