-
Notifications
You must be signed in to change notification settings - Fork 13
Description
Biome Torch Favor Re-Calculation For Placed in World torches does not respect existing modded torch tiles such as Abyss Torch in Calamity and Undersea? torch in Thorium, and ExampleBiome.
Expected Behavior: A placed 'biome-specific' torch (or at least waterproof torches) aren't converted to bone torches by default
Actual Behavior: Waterproof torches placed in water biomes converted and destroyed
Relevant code:
https://github.com/Fargowilta/Fargowiltas/blob/924148a1d26bee910b8cf5b24600e08fa373bf29/Items/Tiles/FargoGlobalTile.cs#L130
Fix would be wrapping that if chain with 'type == TileID.Torches'
Modded torches use a different type; so exampletorch would be type 800 and style zero. But then the calculation changes it to style non-zero and rip torch
Reproduction steps:
- Enable either Thorium or Calamity & Fargo Mutant Mod & Hero's Mod
- Generate appropriate world (Calamity is easier for reproduction, Thorium have to be on the biome edge)
- Right click Teleport to the halfway point of it's abyss
- Cheat in 'Abyss Torches' through Hero's Mod & Enable God Mode for convenience
- Activate Torch God's Favor
- Place Abyss Torch (which is waterproof) in the Abyss.
- see it be placed for a split frame
- Watch as Fargo's Mutant Mod converts it to Bone Torch
Originally reported here:
https://discord.com/channels/232322947694460938/1148085069584547881/1148085069584547881