Re-enable tests not supported before due to CROSS JOIN and OUTER APPLY usage.

Author: niekschoemaker

src/FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests/Query/AdHocNavigationsQueryFbTest.cs

@@ -30,19 +30,19 @@ public class AdHocNavigationsQueryFbTest : AdHocNavigationsQueryRelationalTestBa
 {
 	protected override ITestStoreFactory TestStoreFactory => FbTestStoreFactory.Instance;
 
-	[NotSupportedOnFirebirdFact]
+	[Fact]
 	public override Task Let_multiple_references_with_reference_to_outer()
 	{
 		return base.Let_multiple_references_with_reference_to_outer();
 	}
 
-	[NotSupportedOnFirebirdFact]
+	[Fact]
 	public override Task Projection_with_multiple_includes_and_subquery_with_set_operation()
 	{
 		return base.Projection_with_multiple_includes_and_subquery_with_set_operation();
 	}
 
-	[NotSupportedOnFirebirdFact]
+	[Fact]
 	public override Task SelectMany_and_collection_in_projection_in_FirstOrDefault()
 	{
 		return base.SelectMany_and_collection_in_projection_in_FirstOrDefault();

src/FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests/Query/ComplexNavigationsQueryFbTest.cs

@@ -729,35 +729,35 @@ public override Task Project_shadow_properties10(bool async)
 		return base.Project_shadow_properties10(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task SelectMany_with_outside_reference_to_joined_table_correctly_translated_to_apply(bool isAsync)
 	{
 		return base.SelectMany_with_outside_reference_to_joined_table_correctly_translated_to_apply(isAsync);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task Let_let_contains_from_outer_let(bool async)
 	{
 		return base.Let_let_contains_from_outer_let(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task Prune_does_not_throw_null_ref(bool async)
 	{
 		return base.Prune_does_not_throw_null_ref(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task GroupJoin_with_subquery_on_inner(bool async)
 	{
 		return base.GroupJoin_with_subquery_on_inner(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task GroupJoin_with_subquery_on_inner_and_no_DefaultIfEmpty(bool async)
 	{
@@ -771,21 +771,21 @@ public override Task Nested_SelectMany_correlated_with_join_table_correctly_tran
 		return base.Nested_SelectMany_correlated_with_join_table_correctly_translated_to_apply(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task Correlated_projection_with_first(bool async)
 	{
 		return base.Correlated_projection_with_first(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task Multiple_select_many_in_projection(bool async)
 	{
 		return base.Multiple_select_many_in_projection(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task Single_select_many_in_projection_with_take(bool async)
 	{

src/FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests/Query/NorthwindJoinQueryFbTest.cs

@@ -29,84 +29,84 @@ public NorthwindJoinQueryFbTest(NorthwindQueryFbFixture<NoopModelCustomizer> fix
 		: base(fixture)
 	{ }
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task GroupJoin_as_final_operator(bool async)
 	{
 		return base.GroupJoin_as_final_operator(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task GroupJoin_SelectMany_subquery_with_filter_orderby(bool async)
 	{
 		return base.GroupJoin_SelectMany_subquery_with_filter_orderby(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task GroupJoin_SelectMany_subquery_with_filter_orderby_and_DefaultIfEmpty(bool async)
 	{
 		return base.GroupJoin_SelectMany_subquery_with_filter_orderby_and_DefaultIfEmpty(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task SelectMany_with_client_eval(bool async)
 	{
 		return base.SelectMany_with_client_eval(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task SelectMany_with_client_eval_with_collection_shaper(bool async)
 	{
 		return base.SelectMany_with_client_eval_with_collection_shaper(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task SelectMany_with_client_eval_with_collection_shaper_ignored(bool async)
 	{
 		return base.SelectMany_with_client_eval_with_collection_shaper_ignored(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task SelectMany_with_selecting_outer_element(bool async)
 	{
 		return base.SelectMany_with_selecting_outer_element(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task SelectMany_with_selecting_outer_entity(bool async)
 	{
 		return base.SelectMany_with_selecting_outer_entity(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task SelectMany_with_selecting_outer_entity_column_and_inner_column(bool async)
 	{
 		return base.SelectMany_with_selecting_outer_entity_column_and_inner_column(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task Take_in_collection_projection_with_FirstOrDefault_on_top_level(bool async)
 	{
 		return base.Take_in_collection_projection_with_FirstOrDefault_on_top_level(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task Unflattened_GroupJoin_composed(bool async)
 	{
 		return base.Unflattened_GroupJoin_composed(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task Unflattened_GroupJoin_composed_2(bool async)
 	{

src/FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests/Query/NorthwindSelectQueryFbTest.cs

@@ -45,168 +45,168 @@ public override Task Projection_containing_DateTime_subtraction(bool async)
 		return base.Projection_containing_DateTime_subtraction(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task Project_single_element_from_collection_with_OrderBy_over_navigation_Take_and_FirstOrDefault_2(bool async)
 	{
 		return base.Project_single_element_from_collection_with_OrderBy_over_navigation_Take_and_FirstOrDefault_2(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task Select_nested_collection_deep(bool async)
 	{
 		return base.Select_nested_collection_deep(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task SelectMany_correlated_with_outer_1(bool async)
 	{
 		return base.SelectMany_correlated_with_outer_1(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task SelectMany_correlated_with_outer_2(bool async)
 	{
 		return base.SelectMany_correlated_with_outer_1(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task SelectMany_correlated_with_outer_3(bool async)
 	{
 		return base.SelectMany_correlated_with_outer_1(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task SelectMany_correlated_with_outer_4(bool async)
 	{
 		return base.SelectMany_correlated_with_outer_1(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task SelectMany_correlated_with_outer_5(bool async)
 	{
 		return base.SelectMany_correlated_with_outer_1(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task SelectMany_correlated_with_outer_6(bool async)
 	{
 		return base.SelectMany_correlated_with_outer_1(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task SelectMany_correlated_with_outer_7(bool async)
 	{
 		return base.SelectMany_correlated_with_outer_1(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task SelectMany_with_collection_being_correlated_subquery_which_references_inner_and_outer_entity(bool async)
 	{
 		return base.SelectMany_with_collection_being_correlated_subquery_which_references_inner_and_outer_entity(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task SelectMany_whose_selector_references_outer_source(bool async)
 	{
 		return base.SelectMany_whose_selector_references_outer_source(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task Collection_projection_selecting_outer_element_followed_by_take(bool async)
 	{
 		return base.Collection_projection_selecting_outer_element_followed_by_take(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task Correlated_collection_after_distinct_not_containing_original_identifier(bool async)
 	{
 		return base.Correlated_collection_after_distinct_not_containing_original_identifier(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task Correlated_collection_after_distinct_with_complex_projection_containing_original_identifier(bool async)
 	{
 		return base.Correlated_collection_after_distinct_with_complex_projection_containing_original_identifier(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task Correlated_collection_after_groupby_with_complex_projection_containing_original_identifier(bool async)
 	{
 		return base.Correlated_collection_after_groupby_with_complex_projection_containing_original_identifier(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task Projecting_after_navigation_and_distinct(bool async)
 	{
 		return base.Projecting_after_navigation_and_distinct(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task Select_nested_collection_deep_distinct_no_identifiers(bool async)
 	{
 		return base.Select_nested_collection_deep_distinct_no_identifiers(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task Take_on_correlated_collection_in_first(bool async)
 	{
 		return base.Take_on_correlated_collection_in_first(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task Take_on_top_level_and_on_collection_projection_with_outer_apply(bool async)
 	{
 		return base.Take_on_top_level_and_on_collection_projection_with_outer_apply(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task Correlated_collection_after_groupby_with_complex_projection_not_containing_original_identifier(bool async)
 	{
 		return base.Correlated_collection_after_groupby_with_complex_projection_not_containing_original_identifier(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task Reverse_in_projection_subquery(bool async)
 	{
 		return base.Reverse_in_projection_subquery(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task Reverse_in_projection_subquery_single_result(bool async)
 	{
 		return base.Reverse_in_projection_subquery_single_result(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task Reverse_in_SelectMany_with_Take(bool async)
 	{
 		return base.Reverse_in_SelectMany_with_Take(async);
 	}
 
-	[NotSupportedOnFirebirdTheory]
+	[Theory]
 	[MemberData(nameof(IsAsyncData))]
 	public override Task Set_operation_in_pending_collection(bool async)
 	{