Skip to content

Commit c1acf51

Browse files
Re-enable tests not supported before due to CROSS JOIN and OUTER APPLY usage.
1 parent 201fa33 commit c1acf51

File tree

7 files changed

+70
-70
lines changed

7 files changed

+70
-70
lines changed

src/FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests/Query/AdHocNavigationsQueryFbTest.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,19 +30,19 @@ public class AdHocNavigationsQueryFbTest : AdHocNavigationsQueryRelationalTestBa
3030
{
3131
protected override ITestStoreFactory TestStoreFactory => FbTestStoreFactory.Instance;
3232

33-
[NotSupportedOnFirebirdFact]
33+
[Fact]
3434
public override Task Let_multiple_references_with_reference_to_outer()
3535
{
3636
return base.Let_multiple_references_with_reference_to_outer();
3737
}
3838

39-
[NotSupportedOnFirebirdFact]
39+
[Fact]
4040
public override Task Projection_with_multiple_includes_and_subquery_with_set_operation()
4141
{
4242
return base.Projection_with_multiple_includes_and_subquery_with_set_operation();
4343
}
4444

45-
[NotSupportedOnFirebirdFact]
45+
[Fact]
4646
public override Task SelectMany_and_collection_in_projection_in_FirstOrDefault()
4747
{
4848
return base.SelectMany_and_collection_in_projection_in_FirstOrDefault();

src/FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests/Query/NorthwindJoinQueryFbTest.cs

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -29,84 +29,84 @@ public NorthwindJoinQueryFbTest(NorthwindQueryFbFixture<NoopModelCustomizer> fix
2929
: base(fixture)
3030
{ }
3131

32-
[NotSupportedOnFirebirdTheory]
32+
[Theory]
3333
[MemberData(nameof(IsAsyncData))]
3434
public override Task GroupJoin_as_final_operator(bool async)
3535
{
3636
return base.GroupJoin_as_final_operator(async);
3737
}
3838

39-
[NotSupportedOnFirebirdTheory]
39+
[Theory]
4040
[MemberData(nameof(IsAsyncData))]
4141
public override Task GroupJoin_SelectMany_subquery_with_filter_orderby(bool async)
4242
{
4343
return base.GroupJoin_SelectMany_subquery_with_filter_orderby(async);
4444
}
4545

46-
[NotSupportedOnFirebirdTheory]
46+
[Theory]
4747
[MemberData(nameof(IsAsyncData))]
4848
public override Task GroupJoin_SelectMany_subquery_with_filter_orderby_and_DefaultIfEmpty(bool async)
4949
{
5050
return base.GroupJoin_SelectMany_subquery_with_filter_orderby_and_DefaultIfEmpty(async);
5151
}
5252

53-
[NotSupportedOnFirebirdTheory]
53+
[Theory]
5454
[MemberData(nameof(IsAsyncData))]
5555
public override Task SelectMany_with_client_eval(bool async)
5656
{
5757
return base.SelectMany_with_client_eval(async);
5858
}
5959

60-
[NotSupportedOnFirebirdTheory]
60+
[Theory]
6161
[MemberData(nameof(IsAsyncData))]
6262
public override Task SelectMany_with_client_eval_with_collection_shaper(bool async)
6363
{
6464
return base.SelectMany_with_client_eval_with_collection_shaper(async);
6565
}
6666

67-
[NotSupportedOnFirebirdTheory]
67+
[Theory]
6868
[MemberData(nameof(IsAsyncData))]
6969
public override Task SelectMany_with_client_eval_with_collection_shaper_ignored(bool async)
7070
{
7171
return base.SelectMany_with_client_eval_with_collection_shaper_ignored(async);
7272
}
7373

74-
[NotSupportedOnFirebirdTheory]
74+
[Theory]
7575
[MemberData(nameof(IsAsyncData))]
7676
public override Task SelectMany_with_selecting_outer_element(bool async)
7777
{
7878
return base.SelectMany_with_selecting_outer_element(async);
7979
}
8080

81-
[NotSupportedOnFirebirdTheory]
81+
[Theory]
8282
[MemberData(nameof(IsAsyncData))]
8383
public override Task SelectMany_with_selecting_outer_entity(bool async)
8484
{
8585
return base.SelectMany_with_selecting_outer_entity(async);
8686
}
8787

88-
[NotSupportedOnFirebirdTheory]
88+
[Theory]
8989
[MemberData(nameof(IsAsyncData))]
9090
public override Task SelectMany_with_selecting_outer_entity_column_and_inner_column(bool async)
9191
{
9292
return base.SelectMany_with_selecting_outer_entity_column_and_inner_column(async);
9393
}
9494

95-
[NotSupportedOnFirebirdTheory]
95+
[Theory]
9696
[MemberData(nameof(IsAsyncData))]
9797
public override Task Take_in_collection_projection_with_FirstOrDefault_on_top_level(bool async)
9898
{
9999
return base.Take_in_collection_projection_with_FirstOrDefault_on_top_level(async);
100100
}
101101

102-
[NotSupportedOnFirebirdTheory]
102+
[Theory]
103103
[MemberData(nameof(IsAsyncData))]
104104
public override Task Unflattened_GroupJoin_composed(bool async)
105105
{
106106
return base.Unflattened_GroupJoin_composed(async);
107107
}
108108

109-
[NotSupportedOnFirebirdTheory]
109+
[Theory]
110110
[MemberData(nameof(IsAsyncData))]
111111
public override Task Unflattened_GroupJoin_composed_2(bool async)
112112
{

src/FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests/Query/NorthwindSelectQueryFbTest.cs

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -45,168 +45,168 @@ public override Task Projection_containing_DateTime_subtraction(bool async)
4545
return base.Projection_containing_DateTime_subtraction(async);
4646
}
4747

48-
[NotSupportedOnFirebirdTheory]
48+
[Theory]
4949
[MemberData(nameof(IsAsyncData))]
5050
public override Task Project_single_element_from_collection_with_OrderBy_over_navigation_Take_and_FirstOrDefault_2(bool async)
5151
{
5252
return base.Project_single_element_from_collection_with_OrderBy_over_navigation_Take_and_FirstOrDefault_2(async);
5353
}
5454

55-
[NotSupportedOnFirebirdTheory]
55+
[Theory]
5656
[MemberData(nameof(IsAsyncData))]
5757
public override Task Select_nested_collection_deep(bool async)
5858
{
5959
return base.Select_nested_collection_deep(async);
6060
}
6161

62-
[NotSupportedOnFirebirdTheory]
62+
[Theory]
6363
[MemberData(nameof(IsAsyncData))]
6464
public override Task SelectMany_correlated_with_outer_1(bool async)
6565
{
6666
return base.SelectMany_correlated_with_outer_1(async);
6767
}
6868

69-
[NotSupportedOnFirebirdTheory]
69+
[Theory]
7070
[MemberData(nameof(IsAsyncData))]
7171
public override Task SelectMany_correlated_with_outer_2(bool async)
7272
{
7373
return base.SelectMany_correlated_with_outer_1(async);
7474
}
7575

76-
[NotSupportedOnFirebirdTheory]
76+
[Theory]
7777
[MemberData(nameof(IsAsyncData))]
7878
public override Task SelectMany_correlated_with_outer_3(bool async)
7979
{
8080
return base.SelectMany_correlated_with_outer_1(async);
8181
}
8282

83-
[NotSupportedOnFirebirdTheory]
83+
[Theory]
8484
[MemberData(nameof(IsAsyncData))]
8585
public override Task SelectMany_correlated_with_outer_4(bool async)
8686
{
8787
return base.SelectMany_correlated_with_outer_1(async);
8888
}
8989

90-
[NotSupportedOnFirebirdTheory]
90+
[Theory]
9191
[MemberData(nameof(IsAsyncData))]
9292
public override Task SelectMany_correlated_with_outer_5(bool async)
9393
{
9494
return base.SelectMany_correlated_with_outer_1(async);
9595
}
9696

97-
[NotSupportedOnFirebirdTheory]
97+
[Theory]
9898
[MemberData(nameof(IsAsyncData))]
9999
public override Task SelectMany_correlated_with_outer_6(bool async)
100100
{
101101
return base.SelectMany_correlated_with_outer_1(async);
102102
}
103103

104-
[NotSupportedOnFirebirdTheory]
104+
[Theory]
105105
[MemberData(nameof(IsAsyncData))]
106106
public override Task SelectMany_correlated_with_outer_7(bool async)
107107
{
108108
return base.SelectMany_correlated_with_outer_1(async);
109109
}
110110

111-
[NotSupportedOnFirebirdTheory]
111+
[Theory]
112112
[MemberData(nameof(IsAsyncData))]
113113
public override Task SelectMany_with_collection_being_correlated_subquery_which_references_inner_and_outer_entity(bool async)
114114
{
115115
return base.SelectMany_with_collection_being_correlated_subquery_which_references_inner_and_outer_entity(async);
116116
}
117117

118-
[NotSupportedOnFirebirdTheory]
118+
[Theory]
119119
[MemberData(nameof(IsAsyncData))]
120120
public override Task SelectMany_whose_selector_references_outer_source(bool async)
121121
{
122122
return base.SelectMany_whose_selector_references_outer_source(async);
123123
}
124124

125-
[NotSupportedOnFirebirdTheory]
125+
[Theory]
126126
[MemberData(nameof(IsAsyncData))]
127127
public override Task Collection_projection_selecting_outer_element_followed_by_take(bool async)
128128
{
129129
return base.Collection_projection_selecting_outer_element_followed_by_take(async);
130130
}
131131

132-
[NotSupportedOnFirebirdTheory]
132+
[Theory]
133133
[MemberData(nameof(IsAsyncData))]
134134
public override Task Correlated_collection_after_distinct_not_containing_original_identifier(bool async)
135135
{
136136
return base.Correlated_collection_after_distinct_not_containing_original_identifier(async);
137137
}
138138

139-
[NotSupportedOnFirebirdTheory]
139+
[Theory]
140140
[MemberData(nameof(IsAsyncData))]
141141
public override Task Correlated_collection_after_distinct_with_complex_projection_containing_original_identifier(bool async)
142142
{
143143
return base.Correlated_collection_after_distinct_with_complex_projection_containing_original_identifier(async);
144144
}
145145

146-
[NotSupportedOnFirebirdTheory]
146+
[Theory]
147147
[MemberData(nameof(IsAsyncData))]
148148
public override Task Correlated_collection_after_groupby_with_complex_projection_containing_original_identifier(bool async)
149149
{
150150
return base.Correlated_collection_after_groupby_with_complex_projection_containing_original_identifier(async);
151151
}
152152

153-
[NotSupportedOnFirebirdTheory]
153+
[Theory]
154154
[MemberData(nameof(IsAsyncData))]
155155
public override Task Projecting_after_navigation_and_distinct(bool async)
156156
{
157157
return base.Projecting_after_navigation_and_distinct(async);
158158
}
159159

160-
[NotSupportedOnFirebirdTheory]
160+
[Theory]
161161
[MemberData(nameof(IsAsyncData))]
162162
public override Task Select_nested_collection_deep_distinct_no_identifiers(bool async)
163163
{
164164
return base.Select_nested_collection_deep_distinct_no_identifiers(async);
165165
}
166166

167-
[NotSupportedOnFirebirdTheory]
167+
[Theory]
168168
[MemberData(nameof(IsAsyncData))]
169169
public override Task Take_on_correlated_collection_in_first(bool async)
170170
{
171171
return base.Take_on_correlated_collection_in_first(async);
172172
}
173173

174-
[NotSupportedOnFirebirdTheory]
174+
[Theory]
175175
[MemberData(nameof(IsAsyncData))]
176176
public override Task Take_on_top_level_and_on_collection_projection_with_outer_apply(bool async)
177177
{
178178
return base.Take_on_top_level_and_on_collection_projection_with_outer_apply(async);
179179
}
180180

181-
[NotSupportedOnFirebirdTheory]
181+
[Theory]
182182
[MemberData(nameof(IsAsyncData))]
183183
public override Task Correlated_collection_after_groupby_with_complex_projection_not_containing_original_identifier(bool async)
184184
{
185185
return base.Correlated_collection_after_groupby_with_complex_projection_not_containing_original_identifier(async);
186186
}
187187

188-
[NotSupportedOnFirebirdTheory]
188+
[Theory]
189189
[MemberData(nameof(IsAsyncData))]
190190
public override Task Reverse_in_projection_subquery(bool async)
191191
{
192192
return base.Reverse_in_projection_subquery(async);
193193
}
194194

195-
[NotSupportedOnFirebirdTheory]
195+
[Theory]
196196
[MemberData(nameof(IsAsyncData))]
197197
public override Task Reverse_in_projection_subquery_single_result(bool async)
198198
{
199199
return base.Reverse_in_projection_subquery_single_result(async);
200200
}
201201

202-
[NotSupportedOnFirebirdTheory]
202+
[Theory]
203203
[MemberData(nameof(IsAsyncData))]
204204
public override Task Reverse_in_SelectMany_with_Take(bool async)
205205
{
206206
return base.Reverse_in_SelectMany_with_Take(async);
207207
}
208208

209-
[NotSupportedOnFirebirdTheory]
209+
[Theory]
210210
[MemberData(nameof(IsAsyncData))]
211211
public override Task Set_operation_in_pending_collection(bool async)
212212
{

src/FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests/Query/TPCManyToManyNoTrackingQueryFbTest.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,21 +28,21 @@ public TPCManyToManyNoTrackingQueryFbTest(TPCManyToManyQueryFbFixture fixture)
2828
: base(fixture)
2929
{ }
3030

31-
[NotSupportedOnFirebirdTheory]
31+
[Theory]
3232
[MemberData(nameof(IsAsyncData))]
3333
public override Task Filtered_include_skip_navigation_order_by_skip_take_then_include_skip_navigation_where(bool async)
3434
{
3535
return base.Filtered_include_skip_navigation_order_by_skip_take_then_include_skip_navigation_where(async);
3636
}
3737

38-
[NotSupportedOnFirebirdTheory]
38+
[Theory]
3939
[MemberData(nameof(IsAsyncData))]
4040
public override Task Skip_navigation_order_by_single_or_default(bool async)
4141
{
4242
return base.Skip_navigation_order_by_single_or_default(async);
4343
}
4444

45-
[NotSupportedOnFirebirdTheory]
45+
[Theory]
4646
[MemberData(nameof(IsAsyncData))]
4747
public override Task Filtered_include_skip_navigation_order_by_skip_take_then_include_skip_navigation_where_EF_Property(bool async)
4848
{

src/FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests/Query/TPCManyToManyQueryFbTest.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,21 +28,21 @@ public TPCManyToManyQueryFbTest(TPCManyToManyQueryFbFixture fixture)
2828
: base(fixture)
2929
{ }
3030

31-
[NotSupportedOnFirebirdTheory]
31+
[Theory]
3232
[MemberData(nameof(IsAsyncData))]
3333
public override Task Filtered_include_skip_navigation_order_by_skip_take_then_include_skip_navigation_where(bool async)
3434
{
3535
return base.Filtered_include_skip_navigation_order_by_skip_take_then_include_skip_navigation_where(async);
3636
}
3737

38-
[NotSupportedOnFirebirdTheory]
38+
[Theory]
3939
[MemberData(nameof(IsAsyncData))]
4040
public override Task Skip_navigation_order_by_single_or_default(bool async)
4141
{
4242
return base.Skip_navigation_order_by_single_or_default(async);
4343
}
4444

45-
[NotSupportedOnFirebirdTheory]
45+
[Theory]
4646
[MemberData(nameof(IsAsyncData))]
4747
public override Task Filtered_include_skip_navigation_order_by_skip_take_then_include_skip_navigation_where_EF_Property(bool async)
4848
{

0 commit comments

Comments
 (0)