Skip to content

Commit 05ac197

Browse files
committed
Injected payloadToJsonConverter and payloadEncryptor class instead of the utils static classes
Added setValidateInstruction() Create and reordered tests with correct parameters
1 parent 37b1f98 commit 05ac197

File tree

3 files changed

+701
-111
lines changed

3 files changed

+701
-111
lines changed

raveandroid/src/main/java/com/flutterwave/raveandroid/account/AccountPresenter.java

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,10 @@
88
import com.flutterwave.raveandroid.FeeCheckRequestBody;
99
import com.flutterwave.raveandroid.Payload;
1010
import com.flutterwave.raveandroid.PayloadBuilder;
11+
import com.flutterwave.raveandroid.PayloadEncryptor;
12+
import com.flutterwave.raveandroid.PayloadToJsonConverter;
1113
import com.flutterwave.raveandroid.RavePayInitializer;
1214
import com.flutterwave.raveandroid.TransactionStatusChecker;
13-
import com.flutterwave.raveandroid.Utils;
1415
import com.flutterwave.raveandroid.ViewObject;
1516
import com.flutterwave.raveandroid.card.ChargeRequestBody;
1617
import com.flutterwave.raveandroid.data.Bank;
@@ -89,6 +90,10 @@ public class AccountPresenter implements AccountContract.UserActionsListener {
8990
TransactionStatusChecker transactionStatusChecker;
9091
@Inject
9192
NetworkRequestImpl networkRequest;
93+
@Inject
94+
PayloadToJsonConverter payloadToJsonConverter;
95+
@Inject
96+
PayloadEncryptor payloadEncryptor;
9297

9398
@Inject
9499
AccountPresenter(Context context, AccountContract.View mView) {
@@ -120,8 +125,8 @@ public void onError(String message) {
120125
@Override
121126
public void chargeAccount(final Payload payload, String encryptionKey, final boolean internetBanking) {
122127

123-
String cardRequestBodyAsString = Utils.convertChargeRequestPayloadToJson(payload);
124-
String encryptedCardRequestBody = Utils.getEncryptedData(cardRequestBodyAsString, encryptionKey);
128+
String cardRequestBodyAsString = payloadToJsonConverter.convertChargeRequestPayloadToJson(payload);
129+
String encryptedCardRequestBody = payloadEncryptor.getEncryptedData(cardRequestBodyAsString, encryptionKey);
125130

126131
ChargeRequestBody body = new ChargeRequestBody();
127132
body.setAlg("3DES-24");

raveandroid/src/main/java/com/flutterwave/raveandroid/responses/ChargeResponse.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ public class ChargeResponse {
99
String message;
1010
Data data;
1111

12+
1213
public String getStatus() {
1314
return status;
1415
}
@@ -33,6 +34,7 @@ public void setData(Data data) {
3334
this.data = data;
3435
}
3536

37+
3638
public static class AccountValidateInstructions {
3739
public String getInstruction() {
3840
return instruction;
@@ -60,6 +62,11 @@ public static class Data {
6062
String bankname;
6163
String note;
6264
String amount;
65+
String validateInstruction;
66+
67+
public void setValidateInstruction(String validateInstruction) {
68+
this.validateInstruction = validateInstruction;
69+
}
6370

6471
public String getFlw_reference() {
6572
return flw_reference;
@@ -99,8 +106,6 @@ public String getValidateInstruction() {
99106
return validateInstruction;
100107
}
101108

102-
String validateInstruction;
103-
104109
public String getTx_ref() {
105110
return txRef;
106111
}

0 commit comments

Comments
 (0)