cardNo Validator

Author: mikelis135

raveandroid/src/main/java/com/flutterwave/raveandroid/validators/CardNoValidator.java

@@ -5,6 +5,13 @@
 public class CardNoValidator {
 
     public boolean isCardNoStrippedValid(String cardNoStripped){
-        return !(cardNoStripped.length() < 12 | !Utils.isValidLuhnNumber(cardNoStripped));
+        try{
+            Long.valueOf(cardNoStripped);
+            return !(cardNoStripped.length() < 12 | !Utils.isValidLuhnNumber(cardNoStripped));
+        }
+        catch (NumberFormatException e){
+                return  false;
+        }
+
     }
 }

raveandroid/src/test/java/com/flutterwave/raveandroid/validators/CardExpiryValidatorTest.java

@@ -23,12 +23,17 @@ public void isValidCardExpiry_IsCorrectCardExpiryPassed_returnsTrue(){
     }
 
     @Test
-    public void isValidCardExpiry_IsNumbersCardExpiryPassed_returnsTrue(){
+    public void isValidCardExpiry_IsLettersCardExpiryPassed_returnsFalse(){
         String cardExpiry = "as/11";
         boolean isCardExpiryValid = SUT.isCardExpiryValid(cardExpiry);
         assertThat(false, is(isCardExpiryValid));
     }
 
-
+    @Test
+    public void isValidCardExpiry_IsEmptyCardExpiryPassed_returnsFalse(){
+        String cardExpiry = "";
+        boolean isCardExpiryValid = SUT.isCardExpiryValid(cardExpiry);
+        assertThat(false, is(isCardExpiryValid));
+    }
 
 }

raveandroid/src/test/java/com/flutterwave/raveandroid/validators/CardNoValidatorTest.java

@@ -0,0 +1,51 @@
+package com.flutterwave.raveandroid.validators;
+
+import org.junit.Before;
+import org.junit.Test;
+
+import static org.hamcrest.CoreMatchers.is;
+import static org.junit.Assert.*;
+
+public class CardNoValidatorTest {
+
+    CardNoValidator SUT;
+
+    @Before
+    public void setUp() throws Exception {
+        SUT = new CardNoValidator();
+    }
+
+    @Test
+    public void isCardNoValidator_isCorrectCardNumberPassed_returnsTrue(){
+        String cardNo = "4242424242424242";
+        boolean isCardNoValid = SUT.isCardNoStrippedValid(cardNo);
+        assertThat(true, is(isCardNoValid));
+
+    }
+
+
+    @Test
+    public void isCardNoValidator_isCardLessThan12NumberPassed_returnsFalse(){
+        String cardNo = "42424242424";
+        boolean isCardNoValid = SUT.isCardNoStrippedValid(cardNo);
+        assertThat(false, is(isCardNoValid));
+
+    }
+
+    @Test
+    public void isCardNoValidator_isEmptyCardNumberPassed_returnsFalse(){
+        String cardNo = "";
+        boolean isCardNoValid = SUT.isCardNoStrippedValid(cardNo);
+        assertThat(false, is(isCardNoValid));
+
+    }
+
+    @Test
+    public void isCardNoValidator_isNotNumberPassed_returnsFalse(){
+        String cardNo = "cardNo";
+        boolean isCardNoValid = SUT.isCardNoStrippedValid(cardNo);
+        assertThat(false, is(isCardNoValid));
+
+    }
+
+}