Remove read_phone_state permission. Use Android ID for device ID

Author: jeremiahAI

README-pt-BR.md

@@ -32,15 +32,10 @@ A versão mínima suportada do SDK é 15
 	     implementation 'com.github.Flutterwave:rave-android:1.0.42'
 	}
 
-**Passo 3.** Adicione a permissão necessária
+**Passo 3.** Adicione a permissão de `INTERNET` ao seu android manifest
 
-Adicione as permissões de `READ_PHONE_PERMISSION` e `INTERNET` ao seu android manifest
-
-     <uses-permission android:name="android.permission.READ_PHONE_STATE" />
      <uses-permission android:name="android.permission.INTERNET" />
 
-> **PERMISSÃO NECESSÁRIA**
-> Esta biblioteca requer o ** READ_PHONE_PERMISSION ** para obter o número da compilação para detecção e sinalização de fraude, conforme recomendado aqui https://developer.android.com/training/articles/user-data-ids.html#i_abuse_detection_detecting_high_value_stolen_credentials
 
 ## Uso
 

README.md

@@ -31,15 +31,10 @@ The minimum supported SDK version is 15
 	     implementation 'com.github.Flutterwave:rave-android:1.0.46'
 	}
 
-**Step 3.** Add the required permission
+**Step 3.** Add the  `INTERNET` permission to your android manifest
 
-Add the `READ_PHONE_PERMISSION` and `INTERNET` permissions to your android manifest
-
-     <uses-permission android:name="android.permission.READ_PHONE_STATE" />
      <uses-permission android:name="android.permission.INTERNET" />
 
-> **REQUIRED PERMISSION**
-> This library requires the **READ_PHONE_PERMISSION** to get the build number for fraud detection and flagging as recommended here https://developer.android.com/training/articles/user-data-ids.html#i_abuse_detection_detecting_high_value_stolen_credentials
 
 ## Usage
 

app/src/main/AndroidManifest.xml

@@ -3,7 +3,6 @@
     package="com.flutterwave.rave_android">
 
     <uses-permission android:name="android.permission.ACCESS_WIFI_STATE" />
-    <uses-permission android:name="android.permission.READ_PHONE_STATE" />
     <uses-permission android:name="android.permission.INTERNET" />
 
 

raveandroid/src/main/java/com/flutterwave/raveandroid/DeviceIdGetter.java

@@ -3,28 +3,20 @@
 import android.annotation.SuppressLint;
 import android.content.Context;
 import android.provider.Settings;
-import android.telephony.TelephonyManager;
 
 import javax.inject.Inject;
 
 public class DeviceIdGetter {
 
-    Context context;
-    TelephonyManager telephonyManager;
+    private Context context;
 
     @Inject
-    public DeviceIdGetter(Context context, TelephonyManager telephonyManager) {
+    public DeviceIdGetter(Context context) {
         this.context = context;
-        this.telephonyManager = telephonyManager;
     }
 
+    @SuppressLint("HardwareIds")
     public String getDeviceId() {
-        @SuppressLint("MissingPermission") String ip = telephonyManager.getDeviceId();
-
-        if (ip == null) {
-            ip = Settings.Secure.getString(context.getContentResolver(), Settings.Secure.ANDROID_ID);
-        }
-
-        return ip;
+        return Settings.Secure.getString(context.getContentResolver(), Settings.Secure.ANDROID_ID);
     }
 }

raveandroid/src/main/java/com/flutterwave/raveandroid/OldRavePayActivity.java

@@ -7,7 +7,6 @@
  */
 
 public class RaveConstants {
-    public static int PERMISSIONS_REQUEST_READ_PHONE_STATE = 419;
 
     public static String PUBLIC_KEY = "FLWPUBK-e634d14d9ded04eaf05d5b63a0a06d2f-X"; //test
     public static String ENCRYPTION_KEY = "bb9714020722eb4cf7a169f2";//test