Refactor view and presenter

Author: jeremiahAI

raveandroid/src/main/java/com/flutterwave/raveandroid/banktransfer/BankTransferContract.java

@@ -19,7 +19,7 @@ interface View {
         void displayFee(String charge_amount, Payload payload);
         void showFetchFeeFailed(String s);
         void onPaymentFailed(String message, String responseAsJSONString);
-        void onTransferDetailsReceived(ChargeResponse response);
+        void onTransferDetailsReceived(String amount, String accountNumber, String bankName, String beneficiaryName);
         void onPollingTimeout(String flwRef, String txRef, String responseAsJSONString);
         void onAmountValidationSuccessful(String valueOf);
         void showFieldError(int viewID, String message, Class<?> viewType);

raveandroid/src/main/java/com/flutterwave/raveandroid/banktransfer/BankTransferFragment.java

@@ -188,10 +188,7 @@ private void clearErrors() {
 
     }
 
-    @Override
-    public void onTransferDetailsReceived(ChargeResponse response) {
-        showTransferDetails(response);
-    }
+
 
     @Override
     public void onPollingTimeout(String flwRef, String txRef, final String responseAsJSONString) {
@@ -212,25 +209,6 @@ public void onClick(View view) {
         });
     }
 
-    private void showTransferDetails(ChargeResponse response) {
-        String beneficiaryName = response.getData().getNote().substring(
-                response.getData().getNote().indexOf("to ") + 3
-        );
-
-        amountTv.setText(response.getData().getAmount());
-        beneficiaryNameTv.setText(beneficiaryName);
-        bankNameTv.setText(response.getData().getBankname());
-        accountNumberTv.setText(response.getData().getAccountnumber());
-        transferInstructionTv.setText(
-                transferInstructionTv.getText() + " " + beneficiaryName
-        );
-
-        initiateChargeLayout.setVisibility(GONE);
-        transferDetailsLayout.setVisibility(View.VISIBLE);
-
-
-    }
-
 
     @Override
     public void showProgressIndicator(boolean active) {
@@ -287,6 +265,28 @@ public void onPaymentFailed(String message, final String responseAsJSONString) {
 
     }
 
+    @Override
+    public void onTransferDetailsReceived(String amount, String accountNumber, String bankName, String beneficiaryName) {
+        showTransferDetails(amount, accountNumber, bankName, beneficiaryName);
+    }
+
+    private void showTransferDetails(String amount, String accountNumber, String bankName, String beneficiaryName) {
+
+
+        amountTv.setText(amount);
+        beneficiaryNameTv.setText(beneficiaryName);
+        bankNameTv.setText(bankName);
+        accountNumberTv.setText(accountNumber);
+        transferInstructionTv.setText(
+                transferInstructionTv.getText() + " " + beneficiaryName
+        );
+
+        initiateChargeLayout.setVisibility(GONE);
+        transferDetailsLayout.setVisibility(View.VISIBLE);
+
+
+    }
+
     @Override
     public void displayFee(String charge_amount, final Payload payload) {
         AlertDialog.Builder builder = new AlertDialog.Builder(getActivity());

raveandroid/src/main/java/com/flutterwave/raveandroid/banktransfer/BankTransferPresenter.java

@@ -94,7 +94,14 @@ public void onSuccess(ChargeResponse response, String responseAsJSONString) {
                     flwRef = response.getData().getFlw_reference();
                     txRef = response.getData().getTx_ref();
                     publicKey = payload.getPBFPubKey();
-                    mView.onTransferDetailsReceived(response);
+                    String beneficiaryName = response.getData().getNote().substring(
+                            response.getData().getNote().indexOf("to ") + 3
+                    );
+                    mView.onTransferDetailsReceived(
+                            response.getData().getAmount(),
+                            response.getData().getAccountnumber(),
+                            response.getData().getBankname(),
+                            beneficiaryName);
                 } else {
                     mView.onPaymentError("No response data was returned");
                 }